Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup code smells from sonarcloud #94

Open
jaytaph opened this issue Dec 6, 2020 · 4 comments
Open

Cleanup code smells from sonarcloud #94

jaytaph opened this issue Dec 6, 2020 · 4 comments
Labels
code-cleanup Cleanup or refactoring of the code

Comments

@jaytaph
Copy link
Member

jaytaph commented Dec 6, 2020

Take some time to do a cleanup of the code smells as found in sonarcloud:

https://sonarcloud.io/project/issues?id=bitmaelum_bitmaelum-suite&resolved=false

@jaytaph jaytaph added the code-cleanup Cleanup or refactoring of the code label Dec 6, 2020
@GreenStage
Copy link
Contributor

GreenStage commented Jan 23, 2021

Hi, this project looks interesting, I'm eager to contribute.

This issue presents itself as a nice starting point into your codebase, mind if take it?

@jaytaph
Copy link
Member Author

jaytaph commented Jan 23, 2021

welcome! We're always happy to have new people contribute. You're more than welcome to pick up issues. The code might be a little hard to grasp maybe because there is a lot going on, but most of the sonarcloud issues are doable enough.

@GreenStage
Copy link
Contributor

#171

@jaytaph
Copy link
Member Author

jaytaph commented Jan 24, 2021

image

Pretty nice work done! We got rid of half the code smell issues

I leave this issue open for now, so we can tackle the rest later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-cleanup Cleanup or refactoring of the code
Projects
None yet
Development

No branches or pull requests

2 participants