Merge pull request #249 from federicobond/fix-getfee

Fix getFee returning value instead of failing when called twice
bitpay · Nov 30, 2018 · a8e26c5 · a8e26c5
2 parents 8bb520d + 18eea4b
commit a8e26c5
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/lib/transaction/transaction.js b/lib/transaction/transaction.js
@@ -902,13 +902,11 @@ Transaction.prototype._getOutputAmount = function() {
  */
 Transaction.prototype._getInputAmount = function() {
   if (_.isUndefined(this._inputAmount)) {
-    var self = this;
-    this._inputAmount = 0;
-    _.each(this.inputs, function(input) {
+    this._inputAmount = _.sumBy(this.inputs, function(input) {
       if (_.isUndefined(input.output)) {
         throw new errors.Transaction.Input.MissingPreviousOutput();
       }
-      self._inputAmount += input.output.satoshis;
+      return input.output.satoshis;
     });
   }
   return this._inputAmount;