Skip to content

Commit

Permalink
Better var naming for unbufferedIOEnv
Browse files Browse the repository at this point in the history
  • Loading branch information
lpusok committed Mar 7, 2025
1 parent 54f3caf commit 104354f
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions xcodecommand/xcbeautify.go
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ func (c *XcbeautifyRunner) Run(workDir string, xcodebuildArgs []string, xcbeauti
buildCmd := c.commandFactory.Create("xcodebuild", xcodebuildArgs, &command.Opts{
Stdout: buildOutWriter,
Stderr: buildOutWriter,
Env: xcodeCommandEnvs,
Env: unbufferedIOEnv,
Dir: workDir,
ErrorFinder: errorfinder.FindXcodebuildErrors,
})
Expand All @@ -52,7 +52,7 @@ func (c *XcbeautifyRunner) Run(workDir string, xcodebuildArgs []string, xcbeauti
Stdin: pipeReader,
Stdout: os.Stdout,
Stderr: os.Stderr,
Env: xcodeCommandEnvs,
Env: unbufferedIOEnv,
})

defer func() {
Expand Down
4 changes: 2 additions & 2 deletions xcodecommand/xcodebuild_only.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import (
version "github.com/hashicorp/go-version"
)

var xcodeCommandEnvs = []string{"NSUnbufferedIO=YES"}
var unbufferedIOEnv = []string{"NSUnbufferedIO=YES"}

// RawXcodeCommandRunner is an xcodebuild runner that uses no additional log formatter
type RawXcodeCommandRunner struct {
Expand All @@ -38,7 +38,7 @@ func (c *RawXcodeCommandRunner) Run(workDir string, args []string, _ []string) (
command := c.commandFactory.Create("xcodebuild", args, &command.Opts{
Stdout: &outBuffer,
Stderr: &outBuffer,
Env: xcodeCommandEnvs,
Env: unbufferedIOEnv,
Dir: workDir,
ErrorFinder: errorfinder.FindXcodebuildErrors,
})
Expand Down
2 changes: 1 addition & 1 deletion xcodecommand/xcpretty.go
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ func (c *XcprettyCommandRunner) Run(workDir string, xcodebuildArgs []string, xcp
buildCmd := c.commandFactory.Create("xcodebuild", xcodebuildArgs, &command.Opts{
Stdout: buildOutWriter,
Stderr: buildOutWriter,
Env: xcodeCommandEnvs,
Env: unbufferedIOEnv,
Dir: workDir,
ErrorFinder: errorfinder.FindXcodebuildErrors,
})
Expand Down

0 comments on commit 104354f

Please sign in to comment.