Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible merge with pelotech/drone-helm3? #1

Open
josmo opened this issue Dec 31, 2019 · 4 comments
Open

Possible merge with pelotech/drone-helm3? #1

josmo opened this issue Dec 31, 2019 · 4 comments

Comments

@josmo
Copy link

josmo commented Dec 31, 2019

@foosinn Just wanted to start a conversation on if it made sense to merge this with the pelotech/drone-helm3 plugin since there's a decent amount of overlap :)

@foosinn
Copy link
Contributor

foosinn commented Jan 7, 2020

hey,
limiting to only one helm3 plugin sounds good to me.

what where your reasons to create another version of it?

@josmo
Copy link
Author

josmo commented Jan 7, 2020

@foosinn cool!

definitely didn't plan on having a second one. We started it before this one but then saw it when we went to publish in the registry. So just a timing thing.

@foosinn
Copy link
Contributor

foosinn commented Jan 7, 2020

Code and config of both plugins differ quite a bit. We intentionally broke compatibility, since one needs to migrate anyway. Your approach differs :)

Right now i am not entirely sure if we want to give up control over the plugin. We had some struggles with outdated helm versions in the past.

@josmo
Copy link
Author

josmo commented Jan 7, 2020

Yeah we definitely took a different path (wanted to try to make it as painless for anyone currently using drone-helm and we had quite a few projects using it). We've had probs with the outdated helm versions as well, which is why we setup the repo in a way that forking and enabling publishing of the forked plugin is trivial (using the secrets to define the dockerhub repo) until updates get merged in and doesn't hold folks back (although I think I'd added that to drone-helm a while back :)).

Either way totally get not wanting to give up control. I'm totally down finding a way (now or later) to not have issues with outdatedness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants