Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up legacy code #24

Open
bittner opened this issue Nov 7, 2020 · 1 comment
Open

Clean up legacy code #24

bittner opened this issue Nov 7, 2020 · 1 comment
Labels

Comments

@bittner
Copy link
Owner

bittner commented Nov 7, 2020

There are a few files just lying around, which are effectively unused by the current implementation:

  1. default.odt
  2. default.sty
  3. makeTable.py
  4. to_html.py
  5. to_odt.py
  6. to_tex.py

Their original function is described in an older version of the README (and the french README in the doc folder).

@JanKanis Should we simply remove them to clean up the repository, or rather try to restore the features?

What do you think?

@JanKanis
Copy link

JanKanis commented Nov 9, 2020

Depends on what you want this plugin to be. For 'just' a preview you don't need these features, but apparently the original author thought them to be useful. I'm personally not interested in putting in the work to get these exports working again, but if you want to that is fine. The makeTable function looks useful (ascii art tables are difficult to edit manually), unfortunately it is only one-way so it only helps with the first version and not with then making edits.

If nobody is going to fix these features I would delete the code. As they say, you can always find it back in git. However to make it possible for anyone interested to find the code back I'd add a description and git commit hash+date/link of what was deleted to the README or history-porting file.

On a side note, the reason I started looking into reST preview functionality was because I'm working on a big reST document for which I wanted a live preview with synchronized scrolling. VSCode's reST plugin and another reST editor do synchronized scrolling but they don't work very well for large documents. They appear to just scroll the preview to the same position as the editor window, measured in percentages of the total height. But that doesn't work well with e.g. .. contents:: or commented out text where the height taken up in the source doesn't match the height in the output. In my document the synchronized scrolling would show me parts of the document several screens away from what I was editing. So I searched for a reST preview that does synchronized scrolling that works with large documents, but that doesn't seem to exist. I started to have a look at this gedit plugin as it was in Python, which I know well, and I already used GEdit. So I might give it a try to implement synchronized scrolling that works with large documents, but I won't give any promises as to if or when.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants