Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-11780] Resolve TypeScript 5.3 compile error #11215

Merged
merged 1 commit into from
Oct 1, 2024
Merged

[PM-11780] Resolve TypeScript 5.3 compile error #11215

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions apps/browser/src/platform/browser/browser-api.register-content-scripts-polyfill.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,17 +43,23 @@
function NestedProxy<T extends object>(target: T): T {
return new Proxy(target, {
get(target, prop) {
if (!target[prop as keyof T]) {
const propertyValue = target[prop as keyof T];

if (!propertyValue) {
return;
}

if (typeof target[prop as keyof T] !== "function") {
return NestedProxy(target[prop as keyof T]);
if (typeof propertyValue === "object") {
return NestedProxy<typeof propertyValue>(propertyValue);
}

if (typeof propertyValue !== "function") {
return propertyValue;

Check warning on line 57 in apps/browser/src/platform/browser/browser-api.register-content-scripts-polyfill.ts

View check run for this annotation

Codecov / codecov/patch

apps/browser/src/platform/browser/browser-api.register-content-scripts-polyfill.ts#L57 

Added line #L57 was not covered by tests
}

return (...arguments_: any[]) =>
new Promise((resolve, reject) => {
target[prop as keyof T](...arguments_, (result: any) => {
propertyValue(...arguments_, (result: any) => {
if (chrome.runtime.lastError) {
reject(new Error(chrome.runtime.lastError.message));
} else {
Expand Down
Loading