Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: math lib is not linked in linux #2

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

fix: math lib is not linked in linux #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
47ce5b9
fix: link math lib
mattscamp Jul 31, 2024
2303039
chore: only link for linux
mattscamp Jul 31, 2024
76167cd
chore: fix accidental removal of link to bw
mattscamp Jul 31, 2024
e948c7d
chore: update module for use
mattscamp Aug 1, 2024
2b6f7eb
chore: update reference for use
mattscamp Aug 1, 2024
282d664
chore: update references for use
mattscamp Aug 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bitwarden_client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ package sdk
import (
"encoding/json"

"github.com/bitwarden/sdk-go/internal/cinterface"
"github.com/mattscamp/sdk-go/internal/cinterface"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You left in the module rewrites.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oof. Thought I pushed this to a different branch. Will fix ASAP.

)

type BitwardenClientInterface interface {
Expand Down
2 changes: 1 addition & 1 deletion command_runner.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ package sdk
import (
"encoding/json"

"github.com/bitwarden/sdk-go/internal/cinterface"
"github.com/mattscamp/sdk-go/internal/cinterface"
)

type CommandRunnerInterface interface {
Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module github.com/bitwarden/sdk-go
module github.com/mattscamp/sdk-go

go 1.18
4 changes: 2 additions & 2 deletions internal/cinterface/bitwarden_library.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ import (

/*
#cgo LDFLAGS: -lbitwarden_c
#cgo linux,amd64 LDFLAGS: -L ./lib/linux-x64
#cgo linux,arm64 LDFLAGS: -L ./lib/linux-arm64
#cgo linux,amd64 LDFLAGS: -L ./lib/linux-x64 -lm
#cgo linux,arm64 LDFLAGS: -L ./lib/linux-arm64 -lm
#cgo darwin,amd64 LDFLAGS: -L ./lib/darwin-x64 -framework Security -framework SystemConfiguration
#cgo darwin,arm64 LDFLAGS: -L ./lib/darwin-arm64 -framework Security -framework SystemConfiguration
#cgo windows,amd64 LDFLAGS: -L ./lib/windows-x64 -lbitwarden_c -ladvapi32 -lbcrypt -lcrypt32 -lcryptnet -lkernel32 -lncrypt -lntdll -luserenv -lws2_32 -lmsvcrt
Expand Down