From b829b7b4557c17611164e38520c085b9b3045a4a Mon Sep 17 00:00:00 2001 From: Matt Gibson Date: Mon, 30 Sep 2024 16:24:55 -0700 Subject: [PATCH] Remove flaky sync test --- languages/php/tests/secretsManagerReadTests.php | 7 ------- languages/php/tests/secretsManagerSecretWriteTests.php | 2 -- 2 files changed, 9 deletions(-) diff --git a/languages/php/tests/secretsManagerReadTests.php b/languages/php/tests/secretsManagerReadTests.php index c851be439..f4f4c2d3a 100644 --- a/languages/php/tests/secretsManagerReadTests.php +++ b/languages/php/tests/secretsManagerReadTests.php @@ -85,13 +85,6 @@ function testGetSecret() $this->assertEquals($secret->organizationId, $response->organizationId); } - function testSync() - { - $sync = self::$client->secrets->sync(env('ORGANIZATION_ID'), null); - $this->assertEquals($sync->hasChanges, true); - $this->assertEquals(count(self::$secrets), count($sync->secrets)); - } - function testNoUpdateSync() { $sync = self::$client->secrets->sync(env('ORGANIZATION_ID'), date('Y-m-d\TH:i:s.u\Z')); diff --git a/languages/php/tests/secretsManagerSecretWriteTests.php b/languages/php/tests/secretsManagerSecretWriteTests.php index 469f134f7..186831180 100644 --- a/languages/php/tests/secretsManagerSecretWriteTests.php +++ b/languages/php/tests/secretsManagerSecretWriteTests.php @@ -44,8 +44,6 @@ function testCreateSecret() $toCreate->project_id = self::$writeProject->id; $res = self::$client->secrets->create(env('ORGANIZATION_ID'), $toCreate->key, $toCreate->value, $toCreate->note, [$toCreate->project_id]); - var_dump($res); - var_dump($toCreate); $this->assertEquals($res->key, $toCreate->key); $this->assertEquals($res->value, $toCreate->value); $this->assertEquals($res->note, $toCreate->note);