Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-7066] Make init_crypto take MasterKey #724

Merged
merged 2 commits into from
Apr 22, 2024

Conversation

dani-garcia
Copy link
Member

Type of change

- [ ] Bug fix
- [ ] New feature development
- [x] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

By making the init_crypto_* functions take MasterKey directly, we remove the need for login_method to be set before the init_crypto call. We also centralize the use of the raw password to the MasterKey::derive function, which allows us to more easily secure it.

Copy link
Contributor

github-actions bot commented Apr 22, 2024

Logo
Checkmarx One – Scan Summary & Details2158a19e-daf3-49ec-8b1d-233aa211e5fb

No New Or Fixed Issues Found

Copy link

codecov bot commented Apr 22, 2024

Codecov Report

Attention: Patch coverage is 90.82569% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 60.72%. Comparing base (a5f6fd5) to head (bd8eafb).
Report is 1 commits behind head on main.

Files Patch % Lines
crates/bitwarden/src/auth/login/password.rs 0.00% 8 Missing ⚠️
crates/bitwarden/src/auth/login/api_key.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #724      +/-   ##
==========================================
+ Coverage   60.66%   60.72%   +0.06%     
==========================================
  Files         173      173              
  Lines       10628    10637       +9     
==========================================
+ Hits         6447     6459      +12     
+ Misses       4181     4178       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dani-garcia dani-garcia merged commit a863e89 into main Apr 22, 2024
76 checks passed
@dani-garcia dani-garcia deleted the ps/init-crypto-use-masterkey branch April 22, 2024 11:34
@dani-garcia dani-garcia changed the title Make init_crypto take MasterKey [PM-7066] Make init_crypto take MasterKey Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants