-
Notifications
You must be signed in to change notification settings - Fork 51
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
## Type of change - [ ] Bug fix - [x] New feature development - [x] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective Use a non-root user in Docker. There doesn't seem to be an agreed upon standard for what to name the non-root user, so I named it _app_, as I followed the general guidance from [this MS blog post](https://devblogs.microsoft.com/dotnet/securing-containers-with-rootless/). A `BWS_CONFIG_FILE` environment variable was added to `bws` as well to make it easier to avoid guessing where the correct config file dir is if you are unaware of the _app_ user's name (and therefor, their home directory). ## Code changes - **crates/bws/Dockerfile:** Use a non-root user. - **crates/bws/README.md:** Document using the CLI with Docker. - **crates/bws/src/main.rs:** Add `BWS_CONFIG_FILE` environment variable. - **crates/bws/CHANGELOG.md:** Update changelog. ## Before you submit - Please add **unit tests** where it makes sense to do so
- Loading branch information
1 parent
d5c04a9
commit ff94313
Showing
4 changed files
with
29 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters