Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEVOPS-1785] Replace Ruby publish composite action with individual steps #627

Merged
merged 5 commits into from
Feb 22, 2024

Conversation

michalchecinski
Copy link
Contributor

Type of change

- [x] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [x] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Use individual steps instead of composite action for Ruby publish to rubygem.org. Change is needed because the path where the Ruby code lives cannot be specified in rubygems/release-gem action.

Code changes

  • .github/workflows/publish-ruby.yml Use individual steps instead of composite action for Ruby publish to rubygem.org. Change is needed because the path where the Ruby code lives cannot be specified in rubygems/release-gem action.
  • .github/workflows/build-rust-cross-platform.yml: Remove path in push trigger to build always

Before you submit

  • Please add unit tests where it makes sense to do so

@michalchecinski michalchecinski requested a review from a team as a code owner February 22, 2024 18:54
@michalchecinski michalchecinski enabled auto-merge (squash) February 22, 2024 18:54
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.40%. Comparing base (71c5142) to head (3459aae).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #627   +/-   ##
=======================================
  Coverage   59.40%   59.40%           
=======================================
  Files         171      171           
  Lines       10345    10345           
=======================================
  Hits         6145     6145           
  Misses       4200     4200           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

vgrassia
vgrassia previously approved these changes Feb 22, 2024
@bitwarden-bot
Copy link

bitwarden-bot commented Feb 22, 2024

Logo
Checkmarx One – Scan Summary & Details7f2e2ed5-52c3-4fe5-a288-1234784638d4

No New Or Fixed Issues Found

@michalchecinski michalchecinski merged commit 7724d7d into main Feb 22, 2024
59 checks passed
@michalchecinski michalchecinski deleted the DEVOPS-1785-fix-ruby-publish-step branch February 22, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants