Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback formatting #31

Open
JacobEvelyn opened this issue Oct 3, 2018 · 0 comments
Open

Feedback formatting #31

JacobEvelyn opened this issue Oct 3, 2018 · 0 comments

Comments

@JacobEvelyn
Copy link

I noticed that the feedback that's passed in to the Devise translation sometimes has a trailing period and sometimes does not. This appears to be due to the fact that sometimes we return a sentence and sometimes we use join(". ")—in the latter case the last item won't have a trailing period.

One quick fix would be to either remove the trailing period from line 44, or add one to line 46. But I'm also wondering if this change could instead use newlines instead of periods, as that appears to be what the default Rails/Devise behavior is for other password validations. Does that make sense?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant