Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.minmax should be called on arrays #2641

Closed

Conversation

DaniBitZesty
Copy link
Contributor

@DaniBitZesty DaniBitZesty commented Oct 18, 2023

📝 A short description of the changes

  • This was causing the error undefined method strftime for nil:NilClass
  • (from..to).minmax was returning [nil, nil]
  • .minmax cannot be called on a range, so this converts (from..to) to [from, to] array

https://appsignal.com/bit-zesty/sites/601bea9d7478202eb7a88e16/exceptions/incidents/122/samples/last

🔗 Link to the relevant story (or stories)

:shipit: Deployment implications

✅ Checklist

  • Features that cannot go live are behind a feature flag/env var or specify deploy date and open PR as draft
  • I have checked that commit messages make sense and explain the reasoning for each change
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have squashed any unnecessary or part-finished commits

🖼️ Screenshots (if appropriate - no PII/Prod data):

Copy link
Contributor

@Lubosky Lubosky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants