Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve issue with security mass assignment #2924

Merged
merged 2 commits into from
May 13, 2024

Conversation

Lubosky
Copy link
Contributor

@Lubosky Lubosky commented May 10, 2024

📝 A short description of the changes

Resolved issues flagged by Brakeman concerning mass assignment. Solved by whitelisting keys allowed to be updated.

https://github.com/bitzesty/qae/security/code-scanning/23
https://github.com/bitzesty/qae/security/code-scanning/24

🔗 Link to the relevant story (or stories)

Asana card here: https://app.asana.com/0/1200504523179343/1207221131279488/f

:shipit: Deployment implications

None.

✅ Checklist

  • Features that cannot go live are behind a feature flag/env var or specify deploy date and open PR as draft
  • I have checked that commit messages make sense and explain the reasoning for each change
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have squashed any unnecessary or part-finished commits

🖼️ Screenshots (if appropriate - no PII/Prod data):

@TheDancingClown TheDancingClown merged commit e1cee12 into main May 13, 2024
12 checks passed
@TheDancingClown TheDancingClown deleted the security-mass-assignment branch May 13, 2024 08:01
@TheDancingClown TheDancingClown mentioned this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants