Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make form to submit via post instead of get #2982

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Conversation

Lubosky
Copy link
Contributor

@Lubosky Lubosky commented Jun 24, 2024

📝 A short description of the changes

When creating new application, originally the form was submitted via get method. In terms of validation we were relying on HTML5 built-in validations however the styles did not match the rest of the app. This changes that and form is now submitted via post method (error styles match rest of the application).

🔗 Link to the relevant story (or stories)

Asana card here: https://app.asana.com/0/1200504523179345/1207640920856071/f

:shipit: Deployment implications

None

✅ Checklist

  • Features that cannot go live are behind a feature flag/env var or specify deploy date and open PR as draft
  • I have checked that commit messages make sense and explain the reasoning for each change
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have squashed any unnecessary or part-finished commits

🖼️ Screenshots (if appropriate - no PII/Prod data):

@dreamfall dreamfall merged commit 6011a97 into main Jun 25, 2024
12 checks passed
@dreamfall dreamfall deleted the reference-field-form branch June 25, 2024 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants