Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dynamic error pages and localization #10

Open
solutus opened this issue Mar 11, 2014 · 2 comments
Open

dynamic error pages and localization #10

solutus opened this issue Mar 11, 2014 · 2 comments

Comments

@solutus
Copy link

solutus commented Mar 11, 2014

Hello Bjorn,
I meet some problems with ErrorResponseController.

  1. Localization. Rails maintains public/[errnum].[language].html format. But gem opens public/[errnum].html only.
  2. Dynamic processing of errors. Erb responses and Rails I18 localizations may be used in error pages. http://wearestac.com/blog/dynamic-error-pages-in-rails But current implementation does not allow it.

Currently, I am trying to figure out how to resolve this problems in scope of gem. What do you think about it?

@bjorntrondsen
Copy link
Owner

Hello
You're right, support for dynamic error page content and localization doesnt exist. If you wanna add it yourself you can fork, implement and send a pull request. I dont mind adding it to a future release myself, but I dont have much free time right now so that could take a few weeks or even months.

@phlegx
Copy link

phlegx commented Nov 17, 2015

Hi! Please see my pull request and if you like it merge it to the master branch. Thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants