-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle short form timezone reported by some systems #85
Comments
I'm having second thoughts about the solution I merged yesterday that changed the return value of
The above ☝️ may not be true, even if a returned short form like |
In practice, either way won't change the experience in browsers where |
Our
localTimezone()
function returns unexpected short form timezone names (e.g."CET"
) on some systems. This breaks our tests forlocalTimezone
as well assafeTimezone
on those systems.Seen with Deno 1.39.0 on macOS 14.2
The underlying call is
Intl.DateTimeFormat()?.resolvedOptions()?.timeZone
There are no options affecting returned
timeZone
, so my suggestion is that we rewritelocalTimezone
to fallback to returningUTC
whenever no/
can be found in reportedtimeZone
. The short form will not be useful for the UI anyway, for example the short forms will not be available in a dropdown.The text was updated successfully, but these errors were encountered: