As a WebWorks developer, I can enable string pattern matching in my content #112
Comments
|
@nukulb Updated description. Please review |
|
@kwallis Also thinking we should do the same thing here as we did for the context menu event. Bring it in later so only deliver the enable disable part for the Beta4 and defer the events to the future. This task is unblocked now |
|
Updated description based on design discussions |
|
maybe a param is better here!! but its fine the way it is I guess |
|
I made it disabled because making it a feature, if you include the feature in the config.xml it is basically implicitly saying that it should be enabled. Same argument around removing the "enable" text out of the feature id for flash. |
|
just think its better usability as more apps will want it enabled |
|
I completely agree. At the same time, it seems backwards to be adding a feature to the config, with a param, only to DISABLE a feature. Right now I am leaning to that being just too weird... Ken Wallis Product Manager – BlackBerry WebWorks Research In Motion (905) 629-4746 x14369 From: Nukul Bhasin [[email protected]] just think its better usability as more apps will want it enabled — This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful. |
|
If we want to do this, I don't think it can be a Ken Wallis Product Manager – BlackBerry WebWorks Research In Motion (905) 629-4746 x14369 From: Ken Wallis I completely agree. At the same time, it seems backwards to be adding a feature to the config, with a param, only to DISABLE a feature. Right now I am leaning to that being just too weird... Ken Wallis Product Manager – BlackBerry WebWorks Research In Motion (905) 629-4746 x14369 From: Nukul Bhasin [[email protected]] just think its better usability as more apps will want it enabled — This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful. |
|
I would disagree with that From: Ken Wallis <[email protected]mailto:[email protected]> If we want to do this, I don't think it can be a Ken Wallis Product Manager – BlackBerry WebWorks Research In Motion (905) 629-4746 x14369 From: Ken Wallis I completely agree. At the same time, it seems backwards to be adding a feature to the config, with a param, only to DISABLE a feature. Right now I am leaning to that being just too weird... Ken Wallis Product Manager – BlackBerry WebWorks Research In Motion (905) 629-4746 x14369 From: Nukul Bhasin [[email protected]:[email protected]] just think its better usability as more apps will want it enabled — This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful. — This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful. |
|
Right, but that is all you would ever see in config for string pattern, is to disable it. It is just backwards... Ken Wallis Product Manager – BlackBerry WebWorks Research In Motion (905) 629-4746 x14369 From: Nukul Bhasin [[email protected]] I would disagree with that From: Ken Wallis <[email protected]mailto:[email protected]> If we want to do this, I don't think it can be a Ken Wallis Product Manager – BlackBerry WebWorks Research In Motion (905) 629-4746 x14369 From: Ken Wallis I completely agree. At the same time, it seems backwards to be adding a feature to the config, with a param, only to DISABLE a feature. Right now I am leaning to that being just too weird... Ken Wallis Product Manager – BlackBerry WebWorks Research In Motion (905) 629-4746 x14369 From: Nukul Bhasin [[email protected]:[email protected]] just think its better usability as more apps will want it enabled — This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful. — This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful. — This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful. |
|
fine by me, just imagine that every app needs to add it. |
|
@jrogers is making updates to this as of today. Make sure to touch base with him before implementation. |
|
We already have an existing "InvokeRequest" event that gets emitted by the WebView that will probably be used for this. Basically you will need to listen for that event and process it/pass it to invoke or whatever. It's the same mechanism for string patterns. |
|
@jeffheifetz should already know From: Jeff Rogers [mailto:[email protected]] We already have an existing "InvokeRequest" event that gets emitted by the WebView that will probably be used for this. Basically you will need to listen for that event and process it/pass it to invoke or whatever. It's the same mechanism for string patterns. — This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful. |
|
I should also add that this is a change. Before the browser was processing this in it's LocationChanging event handler. This is what I'm changing as the LocationChanging is a hack. |
|
We had a working implementation using the InvokeRequest event, it was waiting on a bug-fix in the pattern matching itself. |
|
Waiting on internal PR 173340. |
Acceptance Criteria
* This feature should currently be treated as an application-wide feature
* We should open an issue that this feature does not adhere to our usage of elements, in that it is app wide and not part of the implied "local" scope, and is not applicable inside elements.
The text was updated successfully, but these errors were encountered: