Prune unused code

[gtanner]

I am thinking I am seeing a lot of dead / unused code in this project by looking it over:

Examples:

• BBX-Emulator (project hasn't been touched in 4 months and doesn't match the webplatform)
• https://github.com/blackberry-webworks/BB10-WebWorks-Framework/blob/next/lib/public/testbed.html
• https://github.com/blackberry-webworks/BB10-WebWorks-Framework/blob/next/lib/plugins/bridge.js (and unit tests)

I am sure there is a lot more based on my quick glance. The codebase is starting to have a lot of cruft around it and needs to be cleaned up as it is hard to follow what is new / old / used / unused.

[nukulb]

I understand the first two references, what is wrong with bridge.js, I am pretty sure that is still being used.

The bbx-emulator is not being used which is just a matter of removing the submodule reference.
I don't think the testbed.html is being used so I am sure that can go.
There is code that is still here that was used for last deliverable.
We will clean it after this current deliverable.

[gtanner]

I did a quick search for references to it and didn't see any.
I may have grepped incorrectly though.
Sent on the TELUS Mobility network with BlackBerry

[nukulb]

the code for grabbing plugins hasn't been modified, so it is still used in the exact same way as before

[dansilivestru]

Just did a grep, didn't see the bridge used anywhere but in the unit tests.

[nukulb]

Weird, I will get the team to have a look
------Original Message------
From: Dan Silivestru
To: Nukul Bhasin
Subject: Re: [BB10-WebWorks-Framework] Prune unused code (#72)
Sent: Apr 13, 2012 5:21 PM

Just did a grep, didn't see the bridge used anywhere but in the unit tests.

---

Reply to this email directly or view it on GitHub:
#72 (comment)

Sent from my BlackBerry device on the Rogers Wireless Network

[nukulb]

@jeffheifetz confirmed that we are using it, he will comment on this to let you know how exactly, but I believe we don't use it as a require statement.

[jeffheifetz]

The bridge is being used via URI here - https://github.com/blackberry-webworks/BB10-WebWorks-Framework/blob/next/lib/public/window-webworks.js#L131

[gtanner]

Would explain why it didn't come up in a grep, still a lot of pruning to do though :)