Skip to content
This repository has been archived by the owner on Sep 4, 2019. It is now read-only.

configure script shouldn't use sudo #222

Open
gtanner opened this issue Nov 29, 2012 · 4 comments
Open

configure script shouldn't use sudo #222

gtanner opened this issue Nov 29, 2012 · 4 comments

Comments

@gtanner
Copy link
Contributor

gtanner commented Nov 29, 2012

If the person needs to sudo to install global modules they should run:

sudo ./configure

Not everyone needs to run sudo to install global packages and if they do when they just run ./configure it will error out on its own telling them to run it with sudo.

@nukulb
Copy link
Contributor

nukulb commented Nov 29, 2012

Not the entire configure script is designed for sudo so if they sudo ./configure all the submodule permission on .git also get sudo which is not correct.
I agree that its a great place to be currently but I am not sure we have a good solution yet.

From: Gord Tanner <[email protected]mailto:[email protected]>
Reply-To: blackberry/BB10-Webworks-Packager <[email protected]mailto:[email protected]>
Date: Thu, 29 Nov 2012 10:42:30 -0800
To: blackberry/BB10-Webworks-Packager <[email protected]mailto:[email protected]>
Subject: [BB10-Webworks-Packager] configure script shouldn't use sudo (#222)

If the person needs to sudo to install global modules they should run:

sudo ./configure

Not everyone needs to run sudo to install global packages and if they do when they just run ./configure it will error out on its own telling them to run it with sudo.


Reply to this email directly or view it on GitHubhttps://github.com//issues/222.


This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful.

@gtanner
Copy link
Contributor Author

gtanner commented Nov 29, 2012

Yeah, we could look at the $NODE_PATH envvar to see if it contains the user's ID:

echo $NODE_PATH | grep "$(whoami)"

If it does we don't need to sudo to install global modules.

The same problem you described with using sudo to install the global modules is what I am experiencing on my machine (since I don't need to sudo to install them)

@nukulb
Copy link
Contributor

nukulb commented Nov 29, 2012

sounds like a good change.
+1

cc' @jkeshavarzi for scm impact (if at all)

@jamesjhedley
Copy link

So if i understand correctly, we will continue to use ./configure but instead of using sudo to install global packages each and every time; We will check the $NODE_PATH envvar to see if sudo is even necessary.

If this is what we want to do, we should update the issue description.

Not 100% sure if this would affect SCM. They setup their builds pretty weird. Each build is run from an isolated virtual drive.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants