Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open ports occasionally missed due to unwanted deduplication #1842

Closed
TheTechromancer opened this issue Oct 11, 2024 · 1 comment
Closed

Open ports occasionally missed due to unwanted deduplication #1842

TheTechromancer opened this issue Oct 11, 2024 · 1 comment
Assignees
@TheTechromancer
Labels
bug Something isn't working
Milestone
BBOT 2.1.0 - sudd...

Comments

@TheTechromancer
Copy link
Collaborator

After httpx discovers a new URL, if the open port associated with that URL was already seen as an internal event (e.g. from speculate), it will be erroneously deduped, and won't make it into the output.
@TheTechromancer TheTechromancer added the bug Something isn't working label Oct 11, 2024
@TheTechromancer TheTechromancer self-assigned this Oct 11, 2024
@TheTechromancer
Copy link
Collaborator Author

This was due to _outgoing_dedup_hash() not taking .internal into consideration. So modules that emitted the same event multiple ties under different conditions would inadvertently lose data.

Fixed in #1840.

@TheTechromancer TheTechromancer mentioned this issue Oct 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TheTechromancer TheTechromancer

Labels
bug Something isn't working
Projects
None yet
Milestone
BBOT 2.1.0 - sudden_teresa
Development

No branches or pull requests
1 participant
@TheTechromancer