apkpure sometimes downloads .apk files and saves them as .xapk

[domwhewell-sage]

Describe the bug
When running

bbot -t ......... -m google_playstore, apkpure, jadx

BBOT raised 4 MOBILE_APP events (and downloaded them) but jadx only de-compiled 3.

Looking at the debug log you get this

2024-11-09 13:18:29,416 [DEBUG] bbot.modules.jadx base.py:1380 Not accepting FILESYSTEM("{'path': '/home/user/.bbot/scans/effeminate_cthulu/apk_files/.............../com...", module=apkpure, tags={'file'}) because it did not meet custom filter criteria: Jadx is not able to decompile this file type

Running the helper on the file you get this

>>> from bbot.core.helpers.libmagic import get_magic_info
>>> get_magic_info("/home/user/.bbot/scans/effeminate_cthulu/apk_files/........................./.........................xapk")
('.docx', 'application/vnd.openxmlformats-officedocument.wordprocessingml.document', 'MS Office Open XML Format Document', 0.4)

Downloading the file manually the Content-Disposition header is attachment; filename=".................._3.2_APKPure.apk"

So the file is an .apk file but the apkpure module has named it with a .xapk extension causing the helper to not detect the type correctly. (This is the same thats happening in the TestCase mentioned in #1932)

The apkpure module needs modifying so the file extension is not hardcoded and we rather use the Content-Disposition instead (The extension at least the filename has added crap)