Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Punycode validation error #625

Closed
TheTechromancer opened this issue Jul 24, 2023 · 2 comments
Closed

Punycode validation error #625

TheTechromancer opened this issue Jul 24, 2023 · 2 comments
Assignees
@TheTechromancer
Labels
bug Something isn't working low priority Fix these last
Milestone
BBOT 1.1.1 - diff...

Comments

@TheTechromancer
Copy link
Collaborator

TheTechromancer commented Jul 24, 2023 •
edited
Loading 

Malformed DNS_NAME "xn--12c1bik6bbd8ab6hd1b5jc6jta.com" at 34.95.80.156:443

The Thai domain เราเที่ยวด้วยกัน.com apparently is not matched with the \w regex.
@TheTechromancer TheTechromancer added the bug Something isn't working label Jul 24, 2023
@TheTechromancer TheTechromancer self-assigned this Jul 24, 2023
@TheTechromancer TheTechromancer added the low priority Fix these last label Jul 24, 2023
@TheTechromancer
Copy link
Collaborator Author

Based on this it seems like we should be encoding domains to punycode internally, instead of decoding them.

@TheTechromancer TheTechromancer mentioned this issue Sep 18, 2023
Merged
1 task
@TheTechromancer
Copy link
Collaborator Author

Fixed in #741

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TheTechromancer TheTechromancer

Labels
bug Something isn't working low priority Fix these last
Projects
None yet
Milestone
BBOT 1.1.1 - difficult_larry
Development

No branches or pull requests
2 participants
@aconite33 @TheTechromancer