Remove evalf mixin

Author: alesanter

symplyphysics/core/experimental/vectors/__init__.py

@@ -4,7 +4,6 @@
 from typing import Any, Optional, Sequence
 
 from sympy import Add, Atom, Basic, Expr, Mul, S, sympify, ask, Q, simplify
-from sympy.core.evalf import EvalfMixin
 from sympy.core.parameters import global_parameters
 from sympy.physics.units import Dimension
 from sympy.physics.units.systems.si import dimsys_SI
@@ -16,7 +15,7 @@
 from symplyphysics.core.symbols.symbols import DimensionSymbol
 
 
-class VectorExpr(Basic, EvalfMixin):  # type: ignore[misc]
+class VectorExpr(Basic):  # type: ignore[misc]
     """
     Base class for all vector expressions.
     """
@@ -74,9 +73,6 @@ def _sympystr(self, _p: Printer) -> str:
 class VectorSymbol(DimensionSymbol, VectorExpr, Atom):  # type: ignore[misc]
     """
     Class representing a symbolic vector.
-
-    Note that the norm of the vector cannot be `0`, instead, use the pre-defined constant `ZERO`
-    for the zero vector.
     """
 
     _norm: Optional[Expr]
@@ -203,9 +199,6 @@ def _eval_nseries(self, x: Any, n: Any, logx: Any, cdir: Any) -> Any:
     def _sympystr(self, p: Printer) -> str:
         return f"norm({p.doprint(self.argument)})"
 
-    def _eval_evalf(self, prec: int) -> VectorNorm:
-        return VectorNorm(self.argument.evalf(n=prec)).doit()
-
 
 def norm(vector: VectorExpr) -> Expr:
     return VectorNorm(vector).doit()
@@ -296,9 +289,6 @@ def _sympystr(self, p: Printer) -> str:
 
         return f"{p.doprint(vector)}*{p.doprint(value)}"
 
-    def _eval_evalf(self, prec: int) -> VectorScale:
-        return VectorScale(self.vector.evalf(n=prec), self.scale.evalf(n=prec)).doit()
-
 
 class Scale(Expr):  # type: ignore[misc]
     """
@@ -416,9 +406,6 @@ def __hash__(self) -> int:
     def _sympystr(self, p: Printer) -> str:
         return " + ".join(map(p.doprint, self.args))
 
-    def _eval_evalf(self, prec: int) -> VectorAdd:
-        return VectorAdd(*(addend.evalf(n=prec) for addend in self.args)).doit()
-
 
 __all__ = [
     "ZERO",

test/core/experimental/vectors/test_vector.py

@@ -1,5 +1,5 @@
 from pytest import raises
-from sympy import Basic, Symbol as SymSymbol, pi
+from sympy import Basic, Symbol as SymSymbol, Atom
 from symplyphysics import units, dimensionless, symbols, assert_equal
 from symplyphysics.core.expr_comparisons import expr_equals
 from symplyphysics.core.errors import UnitsError
@@ -120,13 +120,6 @@ def test_vector_scaling() -> None:
     scaled_acceleration = scaled_force.subs(force, acceleration)
     assert scaled_acceleration == acceleration * scale
 
-    # .evalf
-
-    # TODO: for some reason this doesn't produce the intended result
-    scaled_vector: VectorScale = force * pi
-    with raises(AssertionError):
-        assert scaled_vector.evalf(3) == force * pi.evalf(3)
-
 
 def test_vector_norm() -> None:
     # VectorSymbol
@@ -164,12 +157,6 @@ def test_vector_norm() -> None:
     # NOTE: We have to force `.doit` after substitution since `__new__` doesn't handle it
     assert norm(force).subs(force, unit).doit() == norm(unit)
 
-    # .evalf
-
-    # NOTE: Both sides differ slightly, (LHS - RHS) / norm(F) = -4.8e-4
-    with raises(AssertionError):
-        assert expr_equals(norm(force * pi).evalf(3), norm(force) * pi.evalf(3))
-
 
 def test_vector_add() -> None:
     force_1 = VectorSymbol("F_1", units.force)
@@ -205,9 +192,3 @@ def test_vector_add() -> None:
 
     # NOTE: We have to force `.doit` after substitution since `__new__` doesn't handle it
     assert sum_123.subs(force_3, force_1).doit() == force_1 * 2 + force_2
-
-    # .evalf
-
-    # NOTE: for some reason, `pi` in the LHS simply gets evaluated with maximum pricision
-    with raises(AssertionError):
-        assert (force_1 * pi + force_2).evalf(3) == force_1 * pi.evalf(3) + force_2