feat(rbx_auth): check csrf token per request #228
Draft
+905
−571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
blake-mealey
commented
Oct 21, 2024
| @@ -13,6 +13,14 @@ target: | |||
| name: Lightweight Mantle Test | |||
| serverFill: | |||
| reservedSlots: 4 | |||
| badges: | |||
There was a problem hiding this comment.
Undo this local testing change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of fetching the CSRF token a single time and caching it in the
RobloxAuthstruct, we implement a middleware-esque approach where we pass as request factory closure to a customCsrfTokenStore.send_requestfunction which will call the factory to construct the request, send the request, then extract the CSRF token from the response headers and resend if necessary.This approach correctly resolves #226 by no longer relying on a deprecated method of receiving a CSRF token.
Additionally, it resolves a long-standing issue of
rbx_auth/rbx_apiwhen used in a long-running context where the CSRF token expires. Now, the token will be automatically refreshed and the request retried.This change does change the public API of both
rbx_authandrbx_apiin a very large way, so this PR should not be merged until the docs have been updated as well.