Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop warning on every call to init #1

Closed
wants to merge 34 commits into from
Closed

Stop warning on every call to init #1

wants to merge 34 commits into from

Conversation

blakef
Copy link
Owner

@blakef blakef commented Jun 20, 2024

  • fix: only show warning about --template & --version when necessary

Summary:

�
When running npx @react-native-community/cli init, you now get a warning:

$ npx @react-native-community/cli@next init TestInit --version next
warn Use --template and --version only if you know what you're doing. Here be dragons 🐉.

It's clearly wrong and should only happen when --version and --template are used together.

Test Plan:

node scripts/build
...
$ node ./packages/cli/build/bin.js init --version next --skip-install --verbose TestInit2
debug Initializing new project
$ node ./packages/cli/build/bin.js init --version next  --template @react-native-community/template@next TestInit --skip-install --verbose
warn Use --template and --version only if you know what you're doing. Here be dragons 🐉.
debug Use the user provided --template=@react-native-community/template@next
debug Initializing new project

LGTM

Checklist

  • Documentation is up to date to reflect these changes.
  • Follows commit message convention described in CONTRIBUTING.md

blakef and others added 30 commits April 12, 2024 08:23
@blakef
feat: check npm and github for template (#2334)
55bda44
@szymonrybczak
fix: downgrade ws package (#2355)
92d2862
@hasunpark @EmmaSnowFlake
@doothez @thymikee
Fixed cannot start Android emulator version 34.1.20.0 (#2358)
2514405 
* Fixed cannot start Android emulator version 34.1.20.0

* Fixed lint error

* refactor: change logic for checking emulator name

* style: specific comment for why we change filter

Co-authored-by: Michał Pierzchała <[email protected]>

* fix: linter issue

---------

Co-authored-by: Sung Hwan Lee <[email protected]>
Co-authored-by: Sung Hwan Lee <[email protected]>
Co-authored-by: Michał Pierzchała <[email protected]>
@thymikee
v14.0.0-alpha.3
be880b8
@szymonrybczak
fix(init): bump Yarn version on older Yarn versions (#2367)
8efbf2c
@thymikee
v14.0.0-alpha.4
73f880c
@szymonrybczak
fix(e2e): sync with React Native 0.74 (#2376)
87881ef 
* fix(e2e): sync with React Native 0.74

* ci: bump gradle

* fix: do not hardcode gradle version

* ci(win): try setting `shell: true`
@szymonrybczak
chore: change react-native executable path key to rnccli (#2374)
0b5f93d 
* chore: change package executable `bin` path

* fix: apply feedback from review
@thymikee
v14.0.0-alpha.5
0bcdb73
@szymonrybczak
ci: skip windows e2e tests in specific scenario (#2386)
21a82d4 
* ci: skip windows e2e tests in specific scenario

* chore: log values

* chore: remove leftovers
@szymonrybczak
chore: upgrade deasync to unblock CI (#2405)
1fbbbc8
@szymonrybczak
chore: remove @react-native-community/cli from bin entrypoints (#…
264d7dd 
…2389)

* chore: remove `@react-native-community/cli` from `bin` entrypoints

* chore: `rnccli` → `rnc-cli`
@szymonrybczak
perf(autolinking): get platform's specific properties (#2379)
b787c89 
* perf(autolinking): get platform's specific properties

* fix: switch param order

* fix: accept object as param in `loadConfig` function
@dependabot
build(deps): bump semver from 7.5.2 to 7.5.3 (#2399)
5933018 
Bumps [semver](https://github.com/npm/node-semver) from 7.5.2 to 7.5.3.
- [Release notes](https://github.com/npm/node-semver/releases)
- [Changelog](https://github.com/npm/node-semver/blob/main/CHANGELOG.md)
- [Commits](npm/node-semver@v7.5.2...v7.5.3)

---
updated-dependencies:
- dependency-name: semver
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@jbroma @thymikee
chore: upgrade parcel to v2 (#2385)
35ffa2e 
* chore: upgrade from parcel-bundler to parcel, remove babel deps

* chore: remove babelrc from debugger-ui

* feat: make parcel use swc instead of babel

* chore: add .parcel-cache to ignored files

* fix: bundling errors

* fix: ignore main when building ui target

* update lockfile

* add --no-cache flag to avoid SIGSEGV error

---------

Co-authored-by: Michał Pierzchała <[email protected]>
@mikehardy
fix: correct derivation of fully specified android launch activities (#…
af5858a 
…2388)

If you have a main activity that is not in package, and is fully specified,
it used to work, but it regressed after adding auto-activity detection

If your launcher / `MAIN` activity either specified by --main-activity or
in AndroidManifest.xml is fully specified for example like
"com.zoontek.rnbootsplash.RNBootSplashActivity" then it needs to launch
for example "com.kullki.kscore.dev/com.zoontek.rnbootsplash.RNBootSplashActivity"
not "com.kullki.kscore.dev/com.kullki.kscore.dev.com.zoontek.rnbootsplash.RNBootSplashActivity"
@dependabot
build(deps): bump jsdom from 16.4.0 to 16.7.0 (#2408)
bf24b50 
Bumps [jsdom](https://github.com/jsdom/jsdom) from 16.4.0 to 16.7.0.
- [Release notes](https://github.com/jsdom/jsdom/releases)
- [Changelog](https://github.com/jsdom/jsdom/blob/main/Changelog.md)
- [Commits](jsdom/jsdom@16.4.0...16.7.0)

---
updated-dependencies:
- dependency-name: jsdom
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
build(deps): bump ansi-regex from 3.0.0 to 3.0.1 (#2407)
a492e01 
Bumps [ansi-regex](https://github.com/chalk/ansi-regex) from 3.0.0 to 3.0.1.
- [Release notes](https://github.com/chalk/ansi-regex/releases)
- [Commits](chalk/ansi-regex@v3.0.0...v3.0.1)

---
updated-dependencies:
- dependency-name: ansi-regex
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@szymonrybczak
Revert "ci: skip windows e2e tests in specific scenario (#2386)" (#2406)
c500a51 
This reverts commit 21a82d4.
@dependabot
build(deps): bump ejs from 3.1.9 to 3.1.10 (#2370)
017a62b 
Bumps [ejs](https://github.com/mde/ejs) from 3.1.9 to 3.1.10.
- [Release notes](https://github.com/mde/ejs/releases)
- [Commits](mde/ejs@v3.1.9...v3.1.10)

---
updated-dependencies:
- dependency-name: ejs
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@szymonrybczak @thymikee
chore(run-android): deprecate --deviceId in favour of --device (#…
efd6bd4 
…2377)

* chore(run-android): deprecate `--deviceId` in favour of `--device`

* fix: option should accept only strings

* Update packages/cli-platform-android/src/commands/runAndroid/index.ts

Co-authored-by: Michał Pierzchała <[email protected]>

---------

Co-authored-by: Michał Pierzchała <[email protected]>
@coder-xiaomo
The *diff link* at update check shows both the old and new versions (#…
7f2a028 
…2373)
@szymonrybczak
fix(ios): prioritize simulators over devices (#2364)
ad237ed
@Jesse-Cameron
fix: allow debugger to connect with custom hosts (#2404)
9c813dc
@szymonrybczak
perf(autolinking)!: prioritise files with *Package.java|*Package.kt…
1754348 
… in `getPackageClassName` (#2384)

* perf(autolinking)!: prioritise files with `*Package.java|*Package.kt` in `getPackageClassName`

* fix: get all files when getting files inside project

* test: add tests
@jbroma
feat: use native fetch from node (#2381)
039f684 
* chore: remove node-fetch

* chore: update node types to newest version

* fix: vendor types for opentype to prevent polluting global namespace with dom types

* feat: use native fetch

* refactor: use absolute minimum of opentype.js typings
@szymonrybczak
feat(run-ios): allow passing UDID inside --device option (#2375)
8944aba 
* feat: allow passing UDID inside `--device` option

* chore: explain device name condition
@DrRefactor
docs: Remove ram-bundle from README (#2411)
0db44d0 
ram-bundle was removed in https://github.com/react-native-community/cli/blob/main/CONTRIBUTING.md#commit-message-convention

Readme points to non-existing command since.
@tido64
fix(apple): parse .xcworkspace for schemes (#2415)
37ba363 
* fix(apple): parse `.xcworkspace` for schemes

* fixup! fix(apple): parse `.xcworkspace` for schemes

* fixup! fix(apple): parse `.xcworkspace` for schemes
@dependabot
build(deps): bump ws from 6.2.2 to 6.2.3 (#2413)
c98ddad 
Bumps [ws](https://github.com/websockets/ws) from 6.2.2 to 6.2.3.
- [Release notes](https://github.com/websockets/ws/releases)
- [Commits](websockets/ws@6.2.2...6.2.3)

---
updated-dependencies:
- dependency-name: ws
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
szymonrybczak and others added 4 commits June 19, 2024 16:28
@szymonrybczak
chore: remove specifying -PreactNativeDebugArchitectures in Android…
33646ef 
… builds (#2416)
@blakef
fix: update react-native version in the template for versions >= 0.75. (
45bc011 
#2417)

* fix: update react-native version in the template for versions >= 0.75.

The new template handling in @react-native-community/template means that
these are shipped with version 1000.0.0 for React Native. The CLI now
owns this.

* fix: --version & --template handling for 0.75

1. Allow using both of these, but only when the user specifies a version
   of react-native >= 0.75. Since templates are now detached there are
   valid use cases for developers and users to specify a template.
   Added a warning about this test(scope): title
2. Exit early for 0.75+ when we can't find a matching
   @react-native-community/template to the version of react-native.
   These should always be matching, but allow for users to remidy this
   by specifying a template. Clearly this should never happen though.

I've also gone to some effort to use concrete versions in the code when
tags are passed.  E.g. --version next, currently maps to 0.75.0-rc0. We
use the latter when looking up templates.

* fix: update @react-native/ scoped packages to match version

From 0.75 our @react-native/ dependencies must match the version of
react-native. Updated init to perform this on
@react-native-community/template.
@thymikee
v14.0.0-alpha.6
3e22589
@blakef
fix: only show warning about --template & --version when necessary
e9473ef 
This is showing at all times, instead of when it's needed.
@blakef blakef closed this Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bugfix docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@blakef @szymonrybczak @hasunpark @thymikee @jbroma @mikehardy @coder-xiaomo @Jesse-Cameron @DrRefactor @tido64