Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing countries in the list #13

Open
AdrianB1 opened this issue Jan 20, 2016 · 5 comments
Open

Missing countries in the list #13

AdrianB1 opened this issue Jan 20, 2016 · 5 comments

Comments

@AdrianB1
Copy link

Comparing to ISO list of countries, there are 7 missing countries:
Åland Islands, Antarctica, Bonaire, Sint Eustatius and Saba, Christmas Island, Cocos (Keeling) Islands (the), Saint Barthélemy, Svalbard and Jan Mayen. I do not comment on how real countries as these, but they have ISO country codes (AX, AQ, BQ,CX, CC, BL and SJ) and flags.

@blazeworx blazeworx added this to the Version 1.1 milestone Jan 22, 2016
@blazeworx
Copy link
Owner

I don't have a problem adding AX, AQ, CX, CC, SJ and BL. They are codes for an individual country / territory and they each have one flag. SJ is its own country code but flies the flag of Norway so that is not a problem. However the problem is BQ. It is actually 3 special municipalities of the Netherlands with one code but 3 flags.

image

In this case I will have to use their BQ-BO code maybe. I will have to think about this some more. Moving this to a v1.2 miletone for the time being.

@blazeworx blazeworx modified the milestones: Version 1.2, Version 1.1 Jan 22, 2016
@AdrianB1
Copy link
Author

Right, they have all individual flags but there is also this: https://en.wikipedia.org/wiki/Caribbean_Netherlands that is suggesting they are using the Nederlands flag for the BQ group and individual flags if taken separately. I would put the Nederlands flag, BQ code and "Bonaire, Sint Eustatius and Saba" as name.

@blazeworx
Copy link
Owner

👍 I agree. I will make the changes.

@AdrianB1
Copy link
Author

Any idea when you will add these countries? If there is any way I can help, I will try, but based on what I saw in the code it should be a 15 minute change.

@telemoes
Copy link

telemoes commented May 1, 2018

Sorry but the thee BQ's are cities of the Netherlands. It are not countries. Every city in the Netherlands have the own flag search on google flag Amsterdam or Rotterdam

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants