Include auction assets #19
Open
+3,064
−408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mootz12
commented
Dec 25, 2024
mootz12
commented
- allow auction creates the ability to specify bid and lot assets in an auction
- add protections against potential misuse of assets to create weird / incomplete liquidations
Ryang-21
requested changes
Dec 27, 2024
Comment on lines
+85
to
116
| match AuctionType::from_u32(e, auction_type) { | ||
| AuctionType::UserLiquidation => { | ||
| let auction_data = create_user_liq_auction_data(e, user, bid, lot, percent); | ||
| storage::set_auction( | ||
| e, | ||
| &(AuctionType::UserLiquidation as u32), | ||
| user, | ||
| &auction_data, | ||
| ); | ||
| auction_data | ||
| } | ||
| AuctionType::BadDebtAuction => { | ||
| let auction_data = create_bad_debt_auction_data(e, user, bid, lot, percent); | ||
| storage::set_auction( | ||
| e, | ||
| &(AuctionType::BadDebtAuction as u32), | ||
| &user, | ||
| &auction_data, | ||
| ); | ||
| auction_data | ||
| } | ||
| AuctionType::InterestAuction => { | ||
| let auction_data = create_interest_auction_data(e, user, bid, lot, percent); | ||
| storage::set_auction( | ||
| e, | ||
| &(AuctionType::InterestAuction as u32), | ||
| &user, | ||
| &auction_data, | ||
| ); | ||
| auction_data | ||
| } | ||
| } |
There was a problem hiding this comment.
This is seems repetitive you could instead return the result of the create_auction function and set it to a variable.
let auction_data = match AuctionType::from_u32(e, auction_type)
Probably also want to have a wild card case that throws an error.
| pub block: u32, | ||
| } | ||
|
|
||
| /// Create a bad debt auction. Stores the resulting auction to the ledger to begin on the next block | ||
| /// Create an new auction. Stores the resulting auction to the ledger to begin on the next block. |
| backstop: &Address, | ||
| assets: &Vec<Address>, | ||
| user: &Address, | ||
| bid: &Vec<Address>, |
There was a problem hiding this comment.
Is there a point to having this arg. Seems like it only serves to throw errors when called incorrectly by a user. Same goes for the lot on bad debt auctions. I suppose it could be confusing if a user specified something in the bid and it wasnt included.
| @@ -43,53 +53,95 @@ pub fn create_user_liq_auction_data( | |||
| panic_with_error!(e, PoolError::InvalidLiquidation); | |||
| } | |||
|
|
|||
| // if a >95% liquidation is requested, default to performing a 100% liquidation. | |||
| // build position data from included assets | |||
| let mut positions_incl = Positions::env_default(e); | |||
There was a problem hiding this comment.
I think auctioned_positions might be a clearer variable name
| ) -> AuctionData { | ||
| if storage::has_auction(e, &(AuctionType::InterestAuction as u32), backstop) { | ||
| let backstop = storage::get_backstop(e); | ||
| if user.clone() != backstop { |
There was a problem hiding this comment.
Suggested change
| if user.clone() != backstop { | |
| if user != &backstop { |
| percent: u32, | ||
| ) -> AuctionData { | ||
| let backstop = storage::get_backstop(e); | ||
| if user.clone() != backstop { |
| ) -> AuctionData { | ||
| let user_clone = user.clone(); | ||
| if user_clone == e.current_contract_address() || user_clone == storage::get_backstop(e) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.