Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BL-001 - “Dead-end” flows (resource limits) #159

Closed
mootz12 opened this issue Dec 18, 2023 · 1 comment
Closed

BL-001 - “Dead-end” flows (resource limits) #159

mootz12 opened this issue Dec 18, 2023 · 1 comment
Assignees

Comments

@mootz12
Copy link
Contributor

mootz12 commented Dec 18, 2023

From Certora Security Report.

There is a potential dead-end flow where a user can amass a large amount of positions and become un-liquidatable due to the health check failing for resource limitations.

Recommended Fix:

  • Limit the number of positions a user can have
@markuspluna
Copy link
Contributor

Resolved in
#174
Which allows pool admins to set a max_positions cap to prevent user's from putting their account in a state where they can't be liquidated due to resource limits

This solution was chosen over a less flexible one (like hardcoding a max position limit) because resource limits are expected to rise over time, thus locking the protocol into a low cap would harm protocol long-term utility

@markuspluna markuspluna self-assigned this Dec 28, 2023
@mootz12 mootz12 closed this as completed Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants