Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BLRC-002 - Potential pitfalls in reserve loading and caching mechanism #168

Closed
mootz12 opened this issue Dec 18, 2023 · 0 comments · Fixed by #180
Closed

BLRC-002 - Potential pitfalls in reserve loading and caching mechanism #168

mootz12 opened this issue Dec 18, 2023 · 0 comments · Fixed by #180
Assignees
@mootz12

Comments

@mootz12
Copy link
Contributor

mootz12 commented Dec 18, 2023

Potential for developer misuse for the writeback pattern with the reserve cacheing mecahnism.

Suggestion to add a drop guard pattern in which the reserve structure is validated to have been written back to storage unless it has been explicitly “defused”.
@mootz12 mootz12 self-assigned this Jan 3, 2024
@mootz12 mootz12 linked a pull request Jan 3, 2024 that will close this issue
pool: chore: make reserve caching system more obvious to use #180
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mootz12 mootz12

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

pool: chore: make reserve caching system more obvious to use blend-capital/blend-contracts
1 participant
@mootz12