Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tools to assistant #329

Merged
merged 12 commits into from
Jun 6, 2024
Merged

feat: add tools to assistant #329

merged 12 commits into from
Jun 6, 2024

Conversation

pixelass
Copy link
Member

@pixelass pixelass commented Jun 4, 2024

Motivation

  • adds ComfyUI tool to allow assistants to generate images.
  • images are stored and multiple images can be generated in one call (e.g. prompt: "Write a story with two images"
  • adds RAG as tool and removes previous RAG implementation

Issues closed

closes #328

Copy link

codacy-production bot commented Jun 4, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (34a7b34) 2114 1986 93.95%
Head commit (45f3011) 2114 (+0) 1986 (+0) 93.95% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#329) 3 3 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@TimPietrusky TimPietrusky self-requested a review June 4, 2024 12:00
Copy link
Member

@TimPietrusky TimPietrusky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice, just two minor changes!

src/client/apps/assistant/components/messages.tsx Outdated Show resolved Hide resolved
src/client/apps/assistant/hooks/assistant.ts Outdated Show resolved Hide resolved
@pixelass pixelass marked this pull request as ready for review June 6, 2024 16:05
@pixelass pixelass changed the title feat: add textToImage tool to assistant feat: add tools to assistant Jun 6, 2024
Copy link
Member

@TimPietrusky TimPietrusky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, LGTM!

@pixelass pixelass merged commit cf1326c into alpha Jun 6, 2024
5 checks passed
@pixelass pixelass deleted the feat/assistant-tools branch June 6, 2024 16:31
TimPietrusky pushed a commit that referenced this pull request Jun 6, 2024
# [1.0.0-alpha.100](v1.0.0-alpha.99...v1.0.0-alpha.100) (2024-06-06)

### Features

* add tools to assistant ([#329](#329)) ([cf1326c](cf1326c)), closes [#328](#328)
@TimPietrusky
Copy link
Member

🎉 This PR is included in version 1.0.0-alpha.100 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tool usage for assistant
2 participants