Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grantinee revokes permissions multiple times for each user #12

Open
JohnBDonner opened this issue Jun 14, 2018 · 1 comment
Open

Grantinee revokes permissions multiple times for each user #12

JohnBDonner opened this issue Jun 14, 2018 · 1 comment
Labels
bug Something isn't working

Comments

@JohnBDonner
Copy link
Contributor

Because we are revoking for every permission for each user, we should probably refactor this so that we only revoke once per user.

I, [2018-06-14T09:21:27.303598 #30]  INFO -- : REVOKE ALL PRIVILEGES ON `database`.* FROM 'some_dude'@'<<host>>';
D, [2018-06-14T09:21:27.304487 #30] DEBUG -- : User some_dude@<<host>> doesn't have any grants yet
I, [2018-06-14T09:21:27.304525 #30]  INFO -- : REVOKE ALL PRIVILEGES ON `database`.* FROM 'some_dude'@'<<host>>';
D, [2018-06-14T09:21:27.305391 #30] DEBUG -- : User some_dude@<<host>> doesn't have any grants yet
I, [2018-06-14T09:21:27.305427 #30]  INFO -- : REVOKE ALL PRIVILEGES ON `database`.* FROM 'some_dude'@'<<host>>';
D, [2018-06-14T09:21:27.306258 #30] DEBUG -- : User some_dude@<<host>> doesn't have any grants yet
I, [2018-06-14T09:21:27.306294 #30]  INFO -- : REVOKE ALL PRIVILEGES ON `database`.* FROM 'some_dude'@'<<host>>';
D, [2018-06-14T09:21:27.307137 #30] DEBUG -- : User some_dude@<<host>> doesn't have any grants yet
I, [2018-06-14T09:21:27.307179 #30]  INFO -- : REVOKE ALL PRIVILEGES ON `database`.* FROM 'some_dude'@'<<host>>';
D, [2018-06-14T09:21:27.308099 #30] DEBUG -- : User some_dude@<<host>> doesn't have any grants yet
I, [2018-06-14T09:21:27.308136 #30]  INFO -- : REVOKE ALL PRIVILEGES ON `database`.* FROM 'some_dude'@'<<host>>';
D, [2018-06-14T09:21:27.308995 #30] DEBUG -- : User some_dude@<<host>> doesn't have any grants yet
I, [2018-06-14T09:21:27.309031 #30]  INFO -- : REVOKE ALL PRIVILEGES ON `database`.* FROM 'some_dude'@'<<host>>';
D, [2018-06-14T09:21:27.309876 #30] DEBUG -- : User some_dude@<<host>> doesn't have any grants yet
I, [2018-06-14T09:21:27.309917 #30]  INFO -- : REVOKE ALL PRIVILEGES ON `database`.* FROM 'some_dude'@'<<host>>';
D, [2018-06-14T09:21:27.310758 #30] DEBUG -- : User some_dude@<<host>> doesn't have any grants yet
...

Not a big issue, but redundant 😃

@JohnBDonner JohnBDonner added the bug Something isn't working label Jun 14, 2018
@pawelkomarnicki
Copy link
Contributor

We could filter and select uniq combinations from the DSL's @permissions array :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants