Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird behavior of Multi-Select in "Hub"-view #432

Closed
hnico21 opened this issue Jan 10, 2025 · 4 comments
Closed

Weird behavior of Multi-Select in "Hub"-view #432

hnico21 opened this issue Jan 10, 2025 · 4 comments
Labels
bug Something isn't working

Comments

@hnico21
Copy link
Contributor

hnico21 commented Jan 10, 2025

Describe the bug
When right-click on a note and selecting "Muliple Select" it does not mark the selected note. instead it marks the last marked or edited note.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Hub' -View
  2. Right-Click on 'Note'
  3. Select 'Multiple Select'
  4. selected Note is not mark. Otherwise try a different note

Expected behavior
note should be marked. This is the behavior in "Blinko" or "Note" - View

Desktop (please complete the following information):

  • Browser [brave]
  • Version [0.35.8]
Copy link

dosubot bot commented Jan 10, 2025

The issue you're experiencing with the "Multiple Select" feature in the "Hub" view might be related to how the handleMultiSelect function is implemented. It seems that the function might not be correctly updating the curMultiSelectIds array with the ID of the note you right-clicked on. Instead, it might be defaulting to the last marked or edited note.

The curMultiSelectIds array is used to track the IDs of notes selected in multi-select mode, and the isMultiSelectMode boolean indicates whether this mode is active. If the function is not correctly adding the right-clicked note's ID to curMultiSelectIds, it could result in the behavior you're seeing [1].

To address this, you might want to check the logic in the onMultiSelectNote method to ensure it correctly handles the ID of the note you right-clicked on. This could involve verifying that the note's ID is being passed and processed correctly when the "Multiple Select" option is chosen.

To continue talking to Dosu, mention @dosu.


Help Dosu learn! Give it feedback: Great Response | Irrelevant Answer | Incorrect Sources | Too Verbose | Hallucination | Other

@dosubot dosubot bot added the bug Something isn't working label Jan 10, 2025
@takeseem
Copy link
Contributor

takeseem commented Jan 11, 2025

多选问题能修复,但是多选后的操作:归档、添加标签、删除,这些对游客来说是无意义的。

你期望的场景是什么?


The multi-selection problem can be fixed, but the operations after multi-selection: archiving, adding tags, and deleting are meaningless to visitors.

What is your expected scenario?

@hnico21
Copy link
Contributor Author

hnico21 commented Jan 11, 2025

I see. You can only edit your own notes. Maybe disable this option in Hub to avoid confusion.

blinko-space added a commit that referenced this issue Jan 27, 2025
- Conditionally wrap card content with ContextMenuTrigger based on share mode
- Simplified event handling for context menu and double-click interactions
- Removed redundant wrapper and improved component readability
@blinko-space
Copy link
Owner

has been removed the right click menu on share mode

github-actions bot pushed a commit that referenced this issue Jan 27, 2025
## [0.37.20](v0.37.19...v0.37.20) (2025-01-27)

### Bug Fixes

* remove right click menu on share mode card [#432](#432) ([8ee0a9d](8ee0a9d))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants