Skip to content

Commit

Permalink
fix: remove implicit JDBC deps (#4103)
Browse files Browse the repository at this point in the history
These make too much log noise when they are included but not used
  • Loading branch information
stuartwdouglas authored Jan 20, 2025
1 parent adee0fd commit 0564918
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 16 deletions.
8 changes: 0 additions & 8 deletions jvm-runtime/ftl-runtime/common/deployment/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -31,14 +31,6 @@
<groupId>io.quarkus</groupId>
<artifactId>quarkus-opentelemetry-deployment</artifactId>
</dependency>
<dependency>
<groupId>io.quarkus</groupId>
<artifactId>quarkus-jdbc-mysql-deployment</artifactId>
</dependency>
<dependency>
<groupId>io.quarkus</groupId>
<artifactId>quarkus-jdbc-postgresql-deployment</artifactId>
</dependency>
<dependency>
<groupId>io.quarkus</groupId>
<artifactId>quarkus-agroal-spi</artifactId>
Expand Down
8 changes: 0 additions & 8 deletions jvm-runtime/ftl-runtime/common/runtime/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -48,14 +48,6 @@
<groupId>io.quarkus</groupId>
<artifactId>quarkus-credentials</artifactId>
</dependency>
<dependency>
<groupId>io.quarkus</groupId>
<artifactId>quarkus-jdbc-mysql</artifactId>
</dependency>
<dependency>
<groupId>io.quarkus</groupId>
<artifactId>quarkus-jdbc-postgresql</artifactId>
</dependency>
<dependency>
<groupId>io.grpc</groupId>
<artifactId>grpc-stub</artifactId>
Expand Down
12 changes: 12 additions & 0 deletions jvm-runtime/jvm_hot_reload_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,18 @@ func TestLifecycleJVM(t *testing.T) {
in.Exec("ftl", "init", "test", "."),
in.IfLanguage("java", in.Exec("ftl", "new", "java", "echo")),
in.IfLanguage("kotlin", in.Exec("ftl", "new", "kotlin", "echo")),
// Add the DB dependency early in the test
// Hot reload is not as smooth with dependency changes
in.EditFile("echo", func(content []byte) []byte {
return []byte(strings.Replace(string(content), "</parent>", `
</parent>
<dependencies>
<dependency>
<groupId>io.quarkus</groupId>
<artifactId>quarkus-jdbc-postgresql</artifactId>
</dependency>
</dependencies>`, 1))
}, "pom.xml"),
in.WaitWithTimeout("echo", time.Minute),
in.VerifyControllerStatus(func(ctx context.Context, t testing.TB, status *ftlv1.StatusResponse) {
assert.Equal(t, 1, len(status.Deployments))
Expand Down

0 comments on commit 0564918

Please sign in to comment.