From 9e4f5d9639b6f5c11553f6d32ada117e18f0eeed Mon Sep 17 00:00:00 2001 From: Alec Thomas Date: Mon, 12 Feb 2024 10:58:09 +1100 Subject: [PATCH] chore: more workflow fixes We need to explicitly tell workflow-roadmap to trigger when one of the other workflows completes. --- .github/workflows/workflow-assigned.yml | 3 ++- .github/workflows/workflow-roadmap.yml | 8 ++++++++ .github/workflows/workflow-triage.yml | 3 ++- 3 files changed, 12 insertions(+), 2 deletions(-) diff --git a/.github/workflows/workflow-assigned.yml b/.github/workflows/workflow-assigned.yml index ddf0de62e5..6d86fb1ac6 100644 --- a/.github/workflows/workflow-assigned.yml +++ b/.github/workflows/workflow-assigned.yml @@ -1,4 +1,5 @@ -name: Remove workflow labels once an issue is assigned +# This name needs to be kept in sync with the workflow_run event in workflow-roadmap.yml +name: Clear workflow labels once an issue is assigned on: issues: types: diff --git a/.github/workflows/workflow-roadmap.yml b/.github/workflows/workflow-roadmap.yml index ef225b60dd..e505ffd35c 100644 --- a/.github/workflows/workflow-roadmap.yml +++ b/.github/workflows/workflow-roadmap.yml @@ -5,6 +5,14 @@ on: - assigned - labeled workflow_dispatch: + # We need to separately trigger when one of the other workflows completes + # because GHA won't trigger another workflow based only on changes from + # another workflow, such as updating labels. + workflow_run: + workflows: + - Add triage label to new issues + - Clear workflow labels once an issue is assigned + types: [completed] jobs: label_issues: runs-on: ubuntu-latest diff --git a/.github/workflows/workflow-triage.yml b/.github/workflows/workflow-triage.yml index 034f84c0f4..33d8183ade 100644 --- a/.github/workflows/workflow-triage.yml +++ b/.github/workflows/workflow-triage.yml @@ -1,4 +1,5 @@ -name: Label issues +# This name needs to be kept in sync with the workflow_run event in workflow-roadmap.yml +name: Add triage label to new issues on: issues: types: