Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use strings for db type everywhere #1380

Open
matt2e opened this issue May 2, 2024 · 2 comments
Open

use strings for db type everywhere #1380

matt2e opened this issue May 2, 2024 · 2 comments
Labels
good first issue Good for newcomers

Comments

@matt2e
Copy link
Collaborator

matt2e commented May 2, 2024

@worstell's new PR uses strings for db types #1374
Previously I had added a db type for modulecontext which was an int. We should move everything to use strings under the hood.

@github-actions github-actions bot added the triage Issue needs triaging label May 2, 2024
@alecthomas alecthomas mentioned this issue May 2, 2024
@worstell worstell added good first issue Good for newcomers and removed triage Issue needs triaging labels May 2, 2024
@mohitsethia
Copy link

Hi @matt2e @worstell , I would like to contribute to this, can you please help a bit as I am new here.

@matt2e
Copy link
Collaborator Author

matt2e commented Jul 24, 2024

@mohitsethia here's some pointers that might help:

This task is to try and move the first type to being a string like the second type and to use the same string values

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants