Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Failed to increase deployment replicas" should be logged at error #899

Closed
alecthomas opened this issue Feb 7, 2024 · 1 comment
Closed

"Failed to increase deployment replicas" should be logged at error #899

alecthomas opened this issue Feb 7, 2024 · 1 comment
Labels
good first issue Good for newcomers

Comments

@alecthomas
Copy link
Collaborator

alecthomas commented Feb 7, 2024 •
edited
Loading

This should really be logged at error, but only if we've already tried to increase replicas and it's failed once.

The other log messages are fine to be at Debug I think.

Originally posted by @alecthomas in #890 (comment)
@github-project-automation github-project-automation bot moved this to Todo in FTL Feb 7, 2024
@github-actions github-actions bot added the triage Issue needs triaging label Feb 7, 2024
@alecthomas alecthomas changed the title This should really be logged at error, but _only_ if we've already tried to increase replicas and it's failed once. "Failed to increase deployment replicas" should be logged at error Feb 7, 2024
@alecthomas alecthomas removed the triage Issue needs triaging label Feb 8, 2024
@wesbillman wesbillman added the good first issue Good for newcomers label Feb 27, 2024
@matt2e
Copy link
Collaborator

matt2e commented Mar 5, 2024

Closing after discussing with @alecthomas, debug is fine for now

@matt2e matt2e closed this as completed Mar 5, 2024
@matt2e matt2e closed this as not planned Won't fix, can't repro, duplicate, stale Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alecthomas @wesbillman @matt2e