Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for kotlin multiplatform #59

Merged
merged 2 commits into from
Mar 18, 2024
Merged

Conversation

jmateoac
Copy link
Collaborator

@jmateoac jmateoac commented Mar 17, 2024

This PR adds support for kotlin multiplatform.
I'm starting small by making Bech32Serde available since it was the easiest to decouple from the jvm.
I tested it on Android, Desktop (Mac M1), and iOS using a Compose Multiplatform app.

Todo

  • Fix publishing so it uses info from the pom file
  • Remove google maven repo

Issues I ran into and how I mitigated them

  • Docker plugins don't work well with multiplatform, so I moved the tests to the lib-test module
  • A vast majority of classes have dependencies on jvm frameworks. I moved them all to the jvmMain source set.
  • I initially added an android target, but removed it because it introduced issues with secp256k1 libs.

@jmateoac jmateoac marked this pull request as ready for review March 17, 2024 01:16
@jmateoac jmateoac merged commit 28b6e69 into main Mar 18, 2024
3 checks passed
@jmateoac jmateoac deleted the jmateo/add_kmm_lib_template branch March 18, 2024 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants