Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing readme information about collectParameterInformation #172

Open
fvito opened this issue Jan 17, 2025 · 0 comments
Open

Missing readme information about collectParameterInformation #172

fvito opened this issue Jan 17, 2025 · 0 comments

Comments

@fvito
Copy link

fvito commented Jan 17, 2025

Hello, I was trying to integrate the library into my compose project, but had an issue described in #159, where composable names were empty, even though I was using latest version which should be compatible with compose 1.7

Looking at the sample project, I was able to pinpoint the issue to the missing call to
currentComposer.collectParameterInformation() in my application.
The sample app calls it here https://github.com/block/radiography/blob/main/sample-compose/src/main/java/com/squareup/radiography/sample/compose/MainActivity.kt#L12

Adding that, fixed the issue. Likewise, removing it from sample app, reproduced the issue.

Perhaps the README should be updated to reflect that this is needed in order to get full composable names in the output. Unsure if there is any way to have this set automatically

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant