Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[front] ETH Scaffold 2: homepage #10

Merged
merged 13 commits into from
Jan 17, 2025
Merged

Conversation

eduramme
Copy link
Contributor

@eduramme eduramme commented Jan 9, 2025

Feature Request

Move the ENS Rental DAPP homepage to the ETH Scaffold 2 monorepo.

@eduramme eduramme linked an issue Jan 9, 2025 that may be closed by this pull request
@pikonha
Copy link
Contributor

pikonha commented Jan 10, 2025

I think we should strip away all the ETH Scaffold-related UI, all we want is the features they provide us under the hood. therefore I think we should:

  • remove the icon from the navbar
image
  • wallet connect
image
  • remove these icons below the page
image
  • remove this footer
image *

@pikonha
Copy link
Contributor

pikonha commented Jan 10, 2025

it would also be useful to remove the scrollbar from the homepage since it isn't being used

Copy link
Contributor

@pikonha pikonha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eduramme eduramme merged commit cbea171 into main Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants