Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace 0x${string} by viem address #126

Open
eduramme opened this issue Aug 8, 2024 · 0 comments
Open

replace 0x${string} by viem address #126

eduramme opened this issue Aug 8, 2024 · 0 comments
Milestone

Comments

@eduramme
Copy link
Collaborator

eduramme commented Aug 8, 2024

I can replace this by the viem's Address type, but I didn't add this MessageData type in this task, I only moved all types from blockchain-txs.ts to a new file to keep the types in a separated file. Maybe we should make a task to replace 0x${string} to "Address" and "Hex" in the whole codebase.

@lgahdl

@eduramme eduramme added this to ENS Aug 8, 2024
@eduramme eduramme converted this from a draft issue Aug 8, 2024
@alextnetto alextnetto changed the title replace ox${string} by viem address replace 0x${string} by viem address Aug 21, 2024
@alextnetto alextnetto added this to the Nice to haves milestone Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ⛰️ Backlog
Development

No branches or pull requests

2 participants