Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Extract and Reuse Common Hex Color Values Across dApp Components #158

Open
eduramme opened this issue Aug 23, 2024 · 1 comment
Labels
enhancement New feature or request
Milestone

Comments

@eduramme
Copy link
Collaborator

Refactor Request

Description

There are several hex color values being used in the codebase that are likely shared across multiple pages and components of the dApp. To improve maintainability and consistency, these hex color values should be extracted into a shared file and reused wherever possible across the project.

Requirements

  • Identify all instances of the same hex color values across different pages and components.
  • Extract these hex color values into a shared file (e.g., a theme or constants file).
  • Refactor the code to reference the shared color values instead of hardcoding them.

Additional Information

  • This change will help in maintaining consistency in the color scheme across the dApp and make future updates to the color palette easier to manage.
  • Consider creating a well-documented and organized shared file that can be easily extended or modified in the future.

#152:
Image

Possible Solution

Extract the common hex color values to a centralized file and update the codebase to use this file wherever those colors are needed. This can be done by creating a constants or theme file that contains all the color values and importing it into the relevant components.

@eduramme eduramme added the enhancement New feature or request label Aug 23, 2024
@eduramme eduramme added this to ENS Aug 23, 2024
@eduramme eduramme moved this to 💡 Ideas in ENS Aug 23, 2024
@FrancoAguzzi
Copy link
Contributor

@eduramme clear and concise! This could be called avatar colors or something like, you know? not good to name the const as the color name because if it changes the information would need to be reupdated once again (the const name :))

@FrancoAguzzi FrancoAguzzi added this to the Nice to haves milestone Sep 9, 2024
@eduramme eduramme removed their assignment Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 💡 Ideas
Development

No branches or pull requests

2 participants