Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Register name with Arbitrum resolver #193

Open
6 tasks
FrancoAguzzi opened this issue Sep 23, 2024 · 3 comments
Open
6 tasks

feat: Register name with Arbitrum resolver #193

FrancoAguzzi opened this issue Sep 23, 2024 · 3 comments
Assignees
Labels
blocked This label indicates that progress on the issue is currently blocked due to an external dependency enhancement New feature or request
Milestone

Comments

@FrancoAguzzi
Copy link
Contributor

FrancoAguzzi commented Sep 23, 2024

Feature Request

Describe the Feature Request

As we are integrating Arbitrum to the dApp, the goal of this issue is to enable the currently disabled Arbitrum Resolver CTA in Name Registration resolver selection step:

Captura de Tela 2024-09-23 às 13 42 39

Describe Preferred Solution

  1. This radio button shall look like the other enabled ones, except from the icon and label;
  2. The ENS resolvers list mapping shall be updated to include Arbitrum resolver and its addresses;
  3. Once user has reached the point of registering the records for the just registered domain, we should ask to switch his network to Arbitrum so he confirms the text records setting transaction. If he is not in Arbitrum, this transaction shall not be sent and his registration flow won't proceed;
  4. Test if the new resolver is being set after a name registration;

Definition of Done

  • The Arbitrum resolver radio button should appear consistent with the other enabled options, differing only in its icon and label.
  • Users can successfully register a name with Arbitrum resolver, the domain should be created on ETH Mainnet.
  • Clear errors should be provided if the process fails due to chain misconfiguration or unsupported chain.
  • Prompt the user to switch to the Arbitrum network when it's time to sign the text records transaction.
  • The new domain should be accessible.
  • The correct text records, expiration date, and address should be displayed after registration.

Related Code

ENSResolverComponent.tsx

@FrancoAguzzi FrancoAguzzi added the enhancement New feature or request label Sep 23, 2024
@FrancoAguzzi FrancoAguzzi added this to the Integrate L2 milestone Sep 23, 2024
@FrancoAguzzi FrancoAguzzi added this to ENS Sep 23, 2024
@FrancoAguzzi FrancoAguzzi moved this to 🔖 TODO in ENS Sep 23, 2024
@FrancoAguzzi
Copy link
Contributor Author

FrancoAguzzi commented Sep 23, 2024

This issue should be initialized after the below one:

feat: add arbitrum support #191

@FrancoAguzzi FrancoAguzzi changed the title feat: update Name Registations available resolvers feat: update Name Registrations enabled resolvers Sep 23, 2024
@FrancoAguzzi FrancoAguzzi changed the title feat: update Name Registrations enabled resolvers feat: when registering a name, enable records setting in an L2 Sep 23, 2024
@FrancoAguzzi FrancoAguzzi changed the title feat: when registering a name, enable records setting in an L2 feat: when registering a name, enable records setting with an L2 resolver Sep 23, 2024
@FrancoAguzzi FrancoAguzzi changed the title feat: when registering a name, enable records setting with an L2 resolver feat: when registering a name, enable records setting with a Arbitrum resolver Sep 23, 2024
@eduramme eduramme changed the title feat: when registering a name, enable records setting with a Arbitrum resolver feat: Register name with Arbitrum resolver Sep 24, 2024
@eduramme eduramme added the blocked This label indicates that progress on the issue is currently blocked due to an external dependency label Sep 24, 2024
@FrancoAguzzi
Copy link
Contributor Author

@eduramme addresses can be found in here

@pikonha
Copy link
Contributor

pikonha commented Sep 27, 2024

same as #197

@pikonha pikonha moved this from 🔖 TODO to 💡 Ideas in ENS Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked This label indicates that progress on the issue is currently blocked due to an external dependency enhancement New feature or request
Projects
Status: Blocked
Development

No branches or pull requests

3 participants