Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more address types #87

Closed
alextnetto opened this issue Jul 22, 2024 · 2 comments · Fixed by #119
Closed

Add more address types #87

alextnetto opened this issue Jul 22, 2024 · 2 comments · Fixed by #119
Assignees
@lgahdl
Labels
enhancement New feature or request

Comments

@alextnetto
Copy link
Member

alextnetto commented Jul 22, 2024 •
edited
Loading

Add more address options: BTC, Optimism, Arbitrum, Polygon.

Image

Docs

Feature is valid when BTC address is shown on ENS dApp Sepolia
@alextnetto alextnetto added this to ENS Jul 22, 2024
@alextnetto alextnetto converted this from a draft issue Jul 22, 2024
@alextnetto alextnetto added the enhancement New feature or request label Jul 22, 2024
@lgahdl lgahdl changed the title Add more account types Add more address types Jul 24, 2024
@lgahdl lgahdl moved this from 🔖 TODO to 🛠️ In Progress in ENS Jul 24, 2024
@lgahdl
Copy link
Contributor

lgahdl commented Jul 24, 2024

Coin Types SLIP44:
https://github.com/satoshilabs/slips/blob/master/slip-0044.md

ETH - 60
BTC - 0
Optimistic ETH - 614
ARB - 9001
MATIC (Polygon) - 966

@alextnetto alextnetto moved this from 🛠️ In Progress to 🕵️‍♀️ In Review in ENS Jul 26, 2024
@eduramme eduramme linked a pull request Jul 29, 2024 that will close this issue
feat: add more address types #119
Merged
@alextnetto alextnetto moved this from 🕵️‍♀️ In Review to Blocked in ENS Jul 29, 2024
@lgahdl
Copy link
Contributor

lgahdl commented Aug 5, 2024

Found out that the Coin Type numbers change(at least for Sepolia Applications):

ETH - 60
BTC - 0
Optimistic ETH - 2147483658
ARB - 2147525809
MATIC (Polygon) - 2147483658

@alextnetto alextnetto moved this from 🔥 QA to ✅ Done in ENS Aug 9, 2024
@alextnetto alextnetto closed this as completed by moving to ✅ Done in ENS Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lgahdl lgahdl

Labels
enhancement New feature or request
Projects
ENS
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add more address types blockful-io/external-resolver-dapp
2 participants
@lgahdl @alextnetto