diff --git a/README.md b/README.md
index 67b5f6c..f683466 100644
--- a/README.md
+++ b/README.md
@@ -5,26 +5,24 @@ SHU. The rewards can be claimed at any time.
The architecture consists of two contracts:
-1. [Staking Architecture](docs/staking-architecture.md): The main contract where keypers can stake SHU tokens and claim rewards.
-2. [Delegate Architecture](docs/delegate-architecture.md): A contract that
- allows users to stake and delegate their SHU tokens to a keyper.
+1. [Staking Architecture](docs/staking-architecture.md): A contract that keypers can stake SHU tokens and claim rewards.
+2. [Delegate Architecture](docs/delegate-architecture.md): A contract that allows users to stake and delegate their SHU tokens to a keyper.
3. [Rewards Distributor Architecture](docs/rewards-distributor.md): A contract
that distributes rewards to the staking and delegate contract at a fixed rate per second.
## Security Considerations
-1. The contracts uses the Ownable pattern where only the DAO has the
+1. The contracts uses the Ownable pattern where only the DAO contract has the
permission to call the owner functions.
-2. The contracts follows the checks-effects-interactions pattern to
+2. The Staking and DelegateStaking contracts are TransparentUpgradeableProxy
+ contracts, which means that the implementation can be upgraded by the proxy
+ owner.
+3. The contracts follows the checks-effects-interactions pattern to
prevent reentrancy attacks.
-3. The contracts has 100% unit test coverage
-4. The contracts has been deployed to the testnet and integration tests
- have been run.
-5. The contracts has integration tests running against the mainnet fork
- to ensure the contract behaves as expected in a real environment.
-6. The contracts has been audited by a third-party security firm.
-7. An AST analyzer has been run on the staking contract.
-8. There are CI checks in place to ensure the code is formatted correctly and
+4. The code has been tested with unit, integration and fuzzing tests.
+5. The contracts has been audited by a independent auditor.
+6. An AST analyzer has been run.
+7. There are CI checks in place to ensure the code is formatted correctly and
the tests pass.
## FAQ
@@ -32,32 +30,39 @@ The architecture consists of two contracts:
1. Is there a deadline for distributing the rewards?
No, the rewards distribution will continue until the rewards contract is depleted.
-2. Can the sSHU token be transferred?
+2. Can the sSHU/dSHU token be transferred?
No, the sSHU token is non-transferable. Keyper can only unstake the SHU
tokens which will burn the sSHU tokens.
3. Is the lock period the same for all stakes?
- No, each stake has an individual lock period determined by the current lock period set by the DAO at the time of keyper's stake. The lock period can be updated by the DAO. If the new lock period is shorter than the current one for that stake, the new lock period will be honored. This allows keyper to trust that their tokens will not be locked for longer than the originally agreed-upon period when they staked, and also enables keyper to unstake their tokens in emergency situations.
+ No, each stake has an individual lock period determined by the current lock
+ period set by the DAO at the time of user's stake. The lock period can be
+ updated by the DAO. If the new lock period is shorter than the current one
+ for that stake, the new lock period will be honored. This allows users to
+ trust that their tokens will not be locked for longer than the originally
+ agreed-upon period when they staked, and also enables them to unstake their tokens in emergency situations.
4. Are the rewards distributed per second or per block?
Per second.
5. Are the rewards calculated based on individual stakes or the total amount of shares the user has?
- The rewards are calculated based on the total amount of shares the keyper
+ The rewards are calculated based on the total amount of shares the users
has. This means that when the keyper claims rewards, they will receive the
rewards for all their stakes.
-6. When unstaking, are the rewards also transferred to the user?
- The keyper has the option to choose whether they want to claim the rewards when they unstake. This is the default behavior.
-
-7. Is there a minimum stake amount for keypers?
+6. Is there a minimum stake amount for keypers?
Yes, there is a minimum amount of SHU tokens that must be staked at the first
- stake. This amount can be set by the DAO. An unstake can never result in a
- balance lower than the minimum stake amount.
+ stake. An unstake can never result in a balance lower than the minimum stake amount.
+ If the Owner is compromised, they could set the minimum stake amount very
+ high, which would prevent keypers from unstaking their tokens. By staking SHU
+ through the Staking contract, keypers trust that the DAO will not set the
+ minimum stake amount to an unreasonable value.
## Protocol Invariants [TBD]
-1. The total amount of SHU tokens staked in the contract must be equal to the
- total amount of SHU tokens staked by each keyper: `totalStaked = sum(stakes[keyper].amount)`.
-2. On unstake, `keyperStake.timestamp + lockPeriod <= block.timestamp` if global `lockPeriod` is greater or equal to the stake lock period, otherwise `keyperStake.timestamp + keyperStake.lockPeriod <= block.timestamp`.
-3. If `some(keyperStakes(keyper).length()) > 0` then `nextStakeId` != 0;
+1. On unstake, `keyperStake.timestamp + lockPeriod <= block.timestamp` if global `lockPeriod` is greater or equal to the stake lock period, otherwise `keyperStake.timestamp + keyperStake.lockPeriod <= block.timestamp`.
+2. If `some(keyperStakes(keyper).length()) > 0` then `nextStakeId` != 0;
+3. amount when staking is greater than 0.
+4. staking never result in a depositor's zero sSHU balance.
+5. withdraw must burn at least the minimim amount of sSHU needed to remove the
+ SHU from the pool.
diff --git a/audit/aderyn-report.md b/audit/aderyn-report.md
new file mode 100644
index 0000000..738b45e
--- /dev/null
+++ b/audit/aderyn-report.md
@@ -0,0 +1,433 @@
+# Aderyn Analysis Report
+
+This report was generated by [Aderyn](https://github.com/Cyfrin/aderyn), a static analysis tool built by [Cyfrin](https://cyfrin.io), a blockchain security company. This report is not a substitute for manual audit or security review. It should not be relied upon for any purpose other than to assist in the identification of potential security vulnerabilities.
+
+# Table of Contents
+
+- [Summary](#summary)
+ - [Files Summary](#files-summary)
+ - [Files Details](#files-details)
+ - [Issue Summary](#issue-summary)
+- [High Issues](#high-issues)
+ - [H-1: Return value of the function call is not checked.](#h-1-return-value-of-the-function-call-is-not-checked)
+- [Low Issues](#low-issues)
+ - [L-1: Centralization Risk for trusted owners](#l-1-centralization-risk-for-trusted-owners)
+ - [L-2: Missing checks for `address(0)` when assigning values to address state variables](#l-2-missing-checks-for-address0-when-assigning-values-to-address-state-variables)
+ - [L-3: `public` functions not used internally could be marked `external`](#l-3-public-functions-not-used-internally-could-be-marked-external)
+ - [L-4: Event is missing `indexed` fields](#l-4-event-is-missing-indexed-fields)
+ - [L-5: Internal functions called only once can be inlined](#l-5-internal-functions-called-only-once-can-be-inlined)
+ - [L-6: Unused Custom Error](#l-6-unused-custom-error)
+
+# Summary
+
+## Files Summary
+
+| Key | Value |
+| ----------- | ----- |
+| .sol Files | 8 |
+| Total nSLOC | 566 |
+
+## Files Details
+
+| Filepath | nSLOC |
+| -------------------------------------- | ------- |
+| src/BaseStaking.sol | 115 |
+| src/DelegateStaking.sol | 110 |
+| src/RewardsDistributor.sol | 87 |
+| src/Staking.sol | 127 |
+| src/interfaces/IERC20.sol | 14 |
+| src/interfaces/IRewardsDistributor.sol | 12 |
+| src/libraries/FixedPointMathLib.sol | 42 |
+| src/libraries/SafeTransferLib.sol | 59 |
+| **Total** | **566** |
+
+## Issue Summary
+
+| Category | No. of Issues |
+| -------- | ------------- |
+| High | 1 |
+| Low | 6 |
+
+# High Issues
+
+## H-1: Return value of the function call is not checked.
+
+Function returns a value but it is ignored.
+
+1 Found Instances
+
+- Found in src/BaseStaking.sol [Line: 91](src/BaseStaking.sol#L91)
+
+ ```solidity
+ rewardsDistributor.collectRewards();
+ ```
+
+10 Found Instances
+
+- Found in src/BaseStaking.sol [Line: 142](src/BaseStaking.sol#L142)
+
+ ```solidity
+ ) external onlyOwner {
+ ```
+
+- Found in src/BaseStaking.sol [Line: 150](src/BaseStaking.sol#L150)
+
+ ```solidity
+ function setLockPeriod(uint256 _lockPeriod) external onlyOwner {
+ ```
+
+- Found in src/DelegateStaking.sol [Line: 252](src/DelegateStaking.sol#L252)
+
+ ```solidity
+ function setStakingContract(address _stakingContract) external onlyOwner {
+ ```
+
+- Found in src/RewardsDistributor.sol [Line: 9](src/RewardsDistributor.sol#L9)
+
+ ```solidity
+ contract RewardsDistributor is Ownable, IRewardsDistributor {
+ ```
+
+- Found in src/RewardsDistributor.sol [Line: 145](src/RewardsDistributor.sol#L145)
+
+ ```solidity
+ ) external override onlyOwner {
+ ```
+
+- Found in src/RewardsDistributor.sol [Line: 162](src/RewardsDistributor.sol#L162)
+
+ ```solidity
+ function removeRewardConfiguration(address receiver) external onlyOwner {
+ ```
+
+- Found in src/RewardsDistributor.sol [Line: 174](src/RewardsDistributor.sol#L174)
+
+ ```solidity
+ ) public override onlyOwner {
+ ```
+
+- Found in src/RewardsDistributor.sol [Line: 180](src/RewardsDistributor.sol#L180)
+
+ ```solidity
+ function setRewardToken(address _rewardToken) external onlyOwner {
+ ```
+
+- Found in src/Staking.sol [Line: 274](src/Staking.sol#L274)
+
+ ```solidity
+ function setMinStake(uint256 _minStake) external onlyOwner {
+ ```
+
+- Found in src/Staking.sol [Line: 284](src/Staking.sol#L284)
+
+ ```solidity
+ function setKeyper(address keyper, bool isKeyper) external onlyOwner {
+ ```
+
+6 Found Instances
+
+- Found in src/DelegateStaking.sol [Line: 138](src/DelegateStaking.sol#L138)
+
+ ```solidity
+ stakingToken = IERC20(_stakingToken);
+ ```
+
+- Found in src/DelegateStaking.sol [Line: 139](src/DelegateStaking.sol#L139)
+
+ ```solidity
+ rewardsDistributor = IRewardsDistributor(_rewardsDistributor);
+ ```
+
+- Found in src/DelegateStaking.sol [Line: 140](src/DelegateStaking.sol#L140)
+
+ ```solidity
+ staking = IStaking(_stakingContract);
+ ```
+
+- Found in src/RewardsDistributor.sol [Line: 73](src/RewardsDistributor.sol#L73)
+
+ ```solidity
+ rewardToken = IERC20(_rewardToken);
+ ```
+
+- Found in src/Staking.sol [Line: 134](src/Staking.sol#L134)
+
+ ```solidity
+ stakingToken = IERC20(_stakingToken);
+ ```
+
+- Found in src/Staking.sol [Line: 135](src/Staking.sol#L135)
+
+ ```solidity
+ rewardsDistributor = IRewardsDistributor(_rewardsDistributor);
+ ```
+
+4 Found Instances
+
+- Found in src/DelegateStaking.sol [Line: 126](src/DelegateStaking.sol#L126)
+
+ ```solidity
+ function initialize(
+ ```
+
+- Found in src/DelegateStaking.sol [Line: 269](src/DelegateStaking.sol#L269)
+
+ ```solidity
+ function maxWithdraw(
+ ```
+
+- Found in src/Staking.sol [Line: 122](src/Staking.sol#L122)
+
+ ```solidity
+ function initialize(
+ ```
+
+- Found in src/Staking.sol [Line: 299](src/Staking.sol#L299)
+
+ ```solidity
+ function maxWithdraw(
+ ```
+
+10 Found Instances
+
+- Found in src/BaseStaking.sol [Line: 58](src/BaseStaking.sol#L58)
+
+ ```solidity
+ event RewardsClaimed(address indexed user, uint256 rewards);
+ ```
+
+- Found in src/DelegateStaking.sol [Line: 83](src/DelegateStaking.sol#L83)
+
+ ```solidity
+ event Staked(
+ ```
+
+- Found in src/DelegateStaking.sol [Line: 91](src/DelegateStaking.sol#L91)
+
+ ```solidity
+ event Unstaked(address indexed user, uint256 amount, uint256 shares);
+ ```
+
+- Found in src/RewardsDistributor.sol [Line: 43](src/RewardsDistributor.sol#L43)
+
+ ```solidity
+ event RewardConfigurationSet(
+ ```
+
+- Found in src/RewardsDistributor.sol [Line: 48](src/RewardsDistributor.sol#L48)
+
+ ```solidity
+ event RewardCollected(address indexed receiver, uint256 reward);
+ ```
+
+- Found in src/Staking.sol [Line: 78](src/Staking.sol#L78)
+
+ ```solidity
+ event Staked(address indexed user, uint256 amount, uint256 lockPeriod);
+ ```
+
+- Found in src/Staking.sol [Line: 81](src/Staking.sol#L81)
+
+ ```solidity
+ event Unstaked(address indexed user, uint256 amount, uint256 shares);
+ ```
+
+- Found in src/Staking.sol [Line: 84](src/Staking.sol#L84)
+
+ ```solidity
+ event KeyperSet(address indexed keyper, bool isKeyper);
+ ```
+
+- Found in src/interfaces/IERC20.sol [Line: 15](src/interfaces/IERC20.sol#L15)
+
+ ```solidity
+ event Transfer(address indexed from, address indexed to, uint256 value);
+ ```
+
+- Found in src/interfaces/IERC20.sol [Line: 21](src/interfaces/IERC20.sol#L21)
+
+ ```solidity
+ event Approval(
+ ```
+
+2 Found Instances
+
+- Found in src/libraries/FixedPointMathLib.sol [Line: 28](src/libraries/FixedPointMathLib.sol#L28)
+
+ ```solidity
+ function mulDivDown(
+ ```
+
+- Found in src/libraries/FixedPointMathLib.sol [Line: 47](src/libraries/FixedPointMathLib.sol#L47)
+
+ ```solidity
+ function mulDivUp(
+ ```
+
+21 Found Instances
+
+- Found in src/BaseStaking.sol [Line: 69](src/BaseStaking.sol#L69)
+
+ ```solidity
+ error WithdrawAmountTooHigh();
+ ```
+
+- Found in src/BaseStaking.sol [Line: 76](src/BaseStaking.sol#L76)
+
+ ```solidity
+ error NoRewardsToClaim();
+ ```
+
+- Found in src/BaseStaking.sol [Line: 79](src/BaseStaking.sol#L79)
+
+ ```solidity
+ error AddressZero();
+ ```
+
+- Found in src/BaseStaking.sol [Line: 82](src/BaseStaking.sol#L82)
+
+ ```solidity
+ error SharesMustBeGreaterThanZero();
+ ```
+
+- Found in src/DelegateStaking.sol [Line: 101](src/DelegateStaking.sol#L101)
+
+ ```solidity
+ error UserHasNoShares();
+ ```
+
+- Found in src/DelegateStaking.sol [Line: 104](src/DelegateStaking.sol#L104)
+
+ ```solidity
+ error ZeroAmount();
+ ```
+
+- Found in src/DelegateStaking.sol [Line: 108](src/DelegateStaking.sol#L108)
+
+ ```solidity
+ error StakeDoesNotBelongToUser();
+ ```
+
+- Found in src/DelegateStaking.sol [Line: 111](src/DelegateStaking.sol#L111)
+
+ ```solidity
+ error StakeDoesNotExist();
+ ```
+
+- Found in src/DelegateStaking.sol [Line: 114](src/DelegateStaking.sol#L114)
+
+ ```solidity
+ error StakeIsStillLocked();
+ ```
+
+- Found in src/DelegateStaking.sol [Line: 117](src/DelegateStaking.sol#L117)
+
+ ```solidity
+ error AddressIsNotAKeyper();
+ ```
+
+- Found in src/RewardsDistributor.sol [Line: 57](src/RewardsDistributor.sol#L57)
+
+ ```solidity
+ error ZeroAddress();
+ ```
+
+- Found in src/RewardsDistributor.sol [Line: 60](src/RewardsDistributor.sol#L60)
+
+ ```solidity
+ error EmissionRateZero();
+ ```
+
+- Found in src/RewardsDistributor.sol [Line: 63](src/RewardsDistributor.sol#L63)
+
+ ```solidity
+ error NotEnoughFunds();
+ ```
+
+- Found in src/RewardsDistributor.sol [Line: 66](src/RewardsDistributor.sol#L66)
+
+ ```solidity
+ error TimeDeltaZero();
+ ```
+
+- Found in src/Staking.sol [Line: 93](src/Staking.sol#L93)
+
+ ```solidity
+ error UserHasNoShares();
+ ```
+
+- Found in src/Staking.sol [Line: 96](src/Staking.sol#L96)
+
+ ```solidity
+ error OnlyKeyper();
+ ```
+
+- Found in src/Staking.sol [Line: 100](src/Staking.sol#L100)
+
+ ```solidity
+ error FirstStakeLessThanMinStake();
+ ```
+
+- Found in src/Staking.sol [Line: 103](src/Staking.sol#L103)
+
+ ```solidity
+ error ZeroAmount();
+ ```
+
+- Found in src/Staking.sol [Line: 107](src/Staking.sol#L107)
+
+ ```solidity
+ error StakeDoesNotBelongToUser();
+ ```
+
+- Found in src/Staking.sol [Line: 110](src/Staking.sol#L110)
+
+ ```solidity
+ error StakeDoesNotExist();
+ ```
+
+- Found in src/Staking.sol [Line: 113](src/Staking.sol#L113)
+
+ ```solidity
+ error StakeIsStillLocked();
+ ```
+
+