From b0522283d522de031e9c18e66814f06f9f9f6ac1 Mon Sep 17 00:00:00 2001 From: Ana Julia Date: Sun, 30 Jun 2024 17:36:11 -0300 Subject: [PATCH] lint --- .solhintrc | 3 ++- lint.yml | 44 -------------------------------------- test/helper/ProxyUtils.sol | 4 ++-- 3 files changed, 4 insertions(+), 47 deletions(-) delete mode 100644 lint.yml diff --git a/.solhintrc b/.solhintrc index 002a423..a4a9806 100644 --- a/.solhintrc +++ b/.solhintrc @@ -7,6 +7,7 @@ "no-inline-assembly": "off", "no-empty-blocks": "off", "no-global-import": "off", - gas-custom-errors": "off", + "gas-custom-errors": "off", + "func-name-mixedcase": "off } } diff --git a/lint.yml b/lint.yml deleted file mode 100644 index 2da1b74..0000000 --- a/lint.yml +++ /dev/null @@ -1,44 +0,0 @@ -name: "Lint" - -env: - FOUNDRY_PROFILE: "ci" - -on: - workflow_dispatch: - pull_request: - push: - branches: - - "main" - -jobs: - lint: - runs-on: ubuntu-latest - steps: - - name: "Check out the repo" - uses: actions/checkout@v3 - with: - submodules: recursive - - name: "Install Node.js" - uses: actions/setup-node@v3 - with: - node-version: lts/* - - - name: "Install the Node.js dependencies" - run: npm install - - - name: Run linter and check for errors - id: lint - run: | - LINT_OUTCOME=$(npm run lint 2>&1 || true) # Prevent the step from failing immediately - echo "$LINT_OUTCOME" - echo "LINT_OUTCOME<> $GITHUB_ENV - echo "$LINT_OUTCOME" >> $GITHUB_ENV - echo "EOF" >> $GITHUB_ENV - if echo "$LINT_OUTCOME" | grep -q " error "; then - echo "## Lint result" >> $GITHUB_STEP_SUMMARY - echo "❌ Failed due to errors" >> $GITHUB_STEP_SUMMARY - exit 1 - else - echo "## Lint result" >> $GITHUB_STEP_SUMMARY - echo "✅ Passed or warnings found" >> $GITHUB_STEP_SUMMARY - fi diff --git a/test/helper/ProxyUtils.sol b/test/helper/ProxyUtils.sol index 42a04d8..a30402d 100644 --- a/test/helper/ProxyUtils.sol +++ b/test/helper/ProxyUtils.sol @@ -5,9 +5,9 @@ import {Vm} from "@forge-std/Vm.sol"; import {ERC1967Utils} from "@openzeppelin/contracts/proxy/ERC1967/ERC1967Utils.sol"; library ProxyUtils { - address constant CHEATCODE_ADDRESS = + address public constant CHEATCODE_ADDRESS = 0x7109709ECfa91a80626fF3989D68f67F5b1DD12D; - Vm constant vm = Vm(CHEATCODE_ADDRESS); + Vm public vm = Vm(CHEATCODE_ADDRESS); function getAdminAddress(address proxy) public view returns (address) { bytes32 adminSlot = vm.load(proxy, ERC1967Utils.ADMIN_SLOT);