-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding quic geyser source and making it work with all raydium pools #5
Conversation
@@ -88,7 +88,8 @@ pub async fn request_mint_metadata( | |||
count.fetch_add(1, Ordering::Relaxed); | |||
} | |||
} | |||
|
|||
// sleep for sometime to avoid overburdening the RPC server | |||
tokio::time::sleep(Duration::from_millis(400)).await; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is that really necessary ? workload is already
a/ send query
b/ wait for response
c/ process response
d/ release lock
There won't be a new cycle before doing b+c+d, so it should not be hammering the rpc (this sleep method would be called about 300 times)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a. I am getting errors without this change, mint accounts are small and are replied fast that is why we are facing this issue.
300 times divided by number of thread.
But can remove it and check if it is working now.
#[serde(deserialize_with = "serde_string_or_env")] | ||
pub rpc_http_url: String, | ||
// does RPC node support getProgramAccountsCompressed | ||
pub rpc_support_compression: Option<bool>, | ||
pub re_snapshot_interval_secs: Option<u64>, | ||
pub grpc_sources: Vec<GrpcSourceConfig>, | ||
pub grpc_sources: Option<Vec<GrpcSourceConfig>>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if it's not optionnal (tx watcher) why make it optional ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is optional because in near future it will be optional when transaction will also be processed by quic. It is easier to make it option right now and remove the check in the code later.
No description provided.