Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'start' from GetTransactions should be uint64 to avoid overflow #17

Open
qiaokan opened this issue Oct 9, 2022 · 0 comments
Open

'start' from GetTransactions should be uint64 to avoid overflow #17

qiaokan opened this issue Oct 9, 2022 · 0 comments

Comments

@qiaokan
Copy link

qiaokan commented Oct 9, 2022

As the current speed of testnet, version can quickly go over int32max
https://github.com/portto/aptos-go-sdk/blob/main/client/transactions.go#L13

start should be uint64, limit can be int or uint64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant