Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SF Request: Fix console warning re: react-media #3143

Closed
kramduckner opened this issue Oct 17, 2022 · 1 comment
Closed

SF Request: Fix console warning re: react-media #3143

kramduckner opened this issue Oct 17, 2022 · 1 comment
Assignees
Labels
sf request Changes requested by the DAHLIA team

Comments

@kramduckner
Copy link
Collaborator

kramduckner commented Oct 17, 2022

Recipe to reproduce warning:

  1. go to a detailed listing page on a desktop width
  2. shrink window to mobile width

It's happening in other scenarios, but this is just one way to repro.

it appears it's coming from a dependency, react-media, and it's a known issue with nextjs - ReactTraining/react-media#139 might be a fix in that thread.

Here's a screenshot of the warning:
Screen Shot 2022-10-27 at 9 03 21 AM

@ludtkemorgan ludtkemorgan added the sf request Changes requested by the DAHLIA team label Oct 18, 2022
@emilyjablonski
Copy link
Collaborator

emilyjablonski commented Nov 14, 2022

Unfortunately, this appears to be an issue within the package itself that is still under investigation and pending a fix (you can see details in the package's issue thread linked above). Afaik it's not producing any functionality issues at the moment and we can keep an eye for when a fix is released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sf request Changes requested by the DAHLIA team
Projects
None yet
Development

No branches or pull requests

3 participants