Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow sms mfa to be toggled on and off #3636

Merged
merged 1 commit into from
Sep 5, 2023
Merged

Conversation

ludtkemorgan
Copy link
Collaborator

@ludtkemorgan ludtkemorgan commented Sep 1, 2023

Pull Request Template

Issue Overview

This PR addresses #issue

  • This change addresses the issue in full
  • This change addresses only certain aspects of the issue
  • This change is a dependency for another issue
  • This change has a dependency from another issue

Description

This pulls the commit over from HBA that gives us the ability to toggle SMS MFA on and off. I think this will be useful going forward to be in core as we will want the ability to remove it in Doorway as well. housingbayarea#637

How Can This Be Tested/Reviewed?

Provide instructions so we can review.

Describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration.

Checklist:

  • My code follows the style guidelines of this project
  • I have added QA notes to the issue with applicable URLs
  • I have performed a self-review of my own code
  • I have reviewed the changes in a desktop view
  • I have reviewed the changes in a mobile view
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have assigned reviewers
  • I have run yarn generate:client and/or created a migration if I made backend changes that require them
  • My commit message(s) is/are polished, and any breaking changes are indicated in the message and are well-described
  • Commits made across packages purposefully have the same commit message/version change, else are separated into different commits

Reviewer Notes:

Steps to review a PR:

  • Read and understand the issue, and ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Also review the acceptance criteria on the Netlify deploy preview (noting that these do not yet include any backend changes made in the PR)
  • Either explicitly ask a clarifying question, request changes, or approve the PR if there are small remaining changes but the PR is otherwise good to go

On Merge:

If you have one commit and message, squash. If you need each message to be applied, rebase and merge.

@netlify
Copy link

netlify bot commented Sep 1, 2023

Deploy Preview for bloom-demo-public ready!

Name Link
🔨 Latest commit dee03b1
🔍 Latest deploy log https://app.netlify.com/sites/bloom-demo-public/deploys/64f22e96093f2900081b1c6a
😎 Deploy Preview https://deploy-preview-3636--bloom-demo-public.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ludtkemorgan ludtkemorgan added the 1 review needed Requires 1 more review before ready to merge label Sep 1, 2023
@netlify
Copy link

netlify bot commented Sep 1, 2023

Deploy Preview for bloom-partners-listings-approval ready!

Name Link
🔨 Latest commit dee03b1
🔍 Latest deploy log https://app.netlify.com/sites/bloom-partners-listings-approval/deploys/64f22e963d228c00072f326d
😎 Deploy Preview https://deploy-preview-3636--bloom-partners-listings-approval.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Sep 1, 2023

Deploy Preview for bloom-exygy-dev ready!

Name Link
🔨 Latest commit dee03b1
🔍 Latest deploy log https://app.netlify.com/sites/bloom-exygy-dev/deploys/64f22e969e2eba000892c972
😎 Deploy Preview https://deploy-preview-3636--bloom-exygy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@emilyjablonski emilyjablonski added ready to merge Should be applied when a PR has been reviewed and approved and removed 1 review needed Requires 1 more review before ready to merge labels Sep 1, 2023
@ludtkemorgan ludtkemorgan merged commit 92add25 into main Sep 5, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Should be applied when a PR has been reviewed and approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants